[MediaWiki-commits] [Gerrit] Fix incorrect code after merge - change (mediawiki...Wikibase)

[Jeroen De Dauw (Code Review)]

Jeroen De Dauw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/65803


Change subject: Fix incorrect code after merge
......................................................................

Fix incorrect code after merge

Change-Id: Ifea7c3737d6d6cf981a87216b1b84f1738ed5685
---
M QueryEngine/includes/SQLStore/EntityRemover.php
M QueryEngine/tests/phpunit/SQLStore/EntityRemoverTest.php
2 files changed, 2 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/03/65803/1

diff --git a/QueryEngine/includes/SQLStore/EntityRemover.php 
b/QueryEngine/includes/SQLStore/EntityRemover.php
index fa25cf8..260e63d 100644
--- a/QueryEngine/includes/SQLStore/EntityRemover.php
+++ b/QueryEngine/includes/SQLStore/EntityRemover.php
@@ -67,10 +67,7 @@
        }
 
        protected function getInternalId( EntityId $entityId ) {
-               return $this->idFinder->getInternalIdForEntity(
-                       $entityId->getEntityType(),
-                       $entityId->getNumericId()
-               );
+               return $this->idFinder->getInternalIdForEntity( $entityId );
        }
 
 }
diff --git a/QueryEngine/tests/phpunit/SQLStore/EntityRemoverTest.php 
b/QueryEngine/tests/phpunit/SQLStore/EntityRemoverTest.php
index 79ca55e..bd6d42a 100644
--- a/QueryEngine/tests/phpunit/SQLStore/EntityRemoverTest.php
+++ b/QueryEngine/tests/phpunit/SQLStore/EntityRemoverTest.php
@@ -69,8 +69,7 @@
                $idFinder->expects( $this->any() )
                        ->method( 'getInternalIdForEntity' )
                        ->with(
-                               $entity->getId()->getEntityType(),
-                               $entity->getId()->getNumericId()
+                               $entity->getId()
                        )
                        ->will( $this->returnValue( 1234 ) );
 

-- 
To view, visit https://gerrit.wikimedia.org/r/65803
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifea7c3737d6d6cf981a87216b1b84f1738ed5685
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <jeroended...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits