Mark Bergsma has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/65808


Change subject: The wikimedia_nets ACL isn't always defined
......................................................................

The wikimedia_nets ACL isn't always defined

Change-Id: Ic0109e2a0147ab4a1bb81688f66e6630e9cc23e8
---
M templates/varnish/wikimedia.vcl.erb
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/08/65808/1

diff --git a/templates/varnish/wikimedia.vcl.erb 
b/templates/varnish/wikimedia.vcl.erb
index daa056a..06484f3 100644
--- a/templates/varnish/wikimedia.vcl.erb
+++ b/templates/varnish/wikimedia.vcl.erb
@@ -191,12 +191,14 @@
        }
 }
 
+<% if ! wikimedia_networks.empty? -%>
 sub restrict_access {
        if (client.ip !~ wikimedia_nets) {
                error 403 "Access denied";
        }
 }
 
+<% end -%>
 sub vcl_recv {
        if (req.request != "GET" && req.request != "HEAD" && req.request != 
"POST" && req.request != "PURGE") {
                /* We only deal with GET, HEAD and POST by default */

-- 
To view, visit https://gerrit.wikimedia.org/r/65808
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic0109e2a0147ab4a1bb81688f66e6630e9cc23e8
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Mark Bergsma <m...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to