Ori.livneh has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/66315


Change subject: Don't display confirmation if core is already doing it
......................................................................

Don't display confirmation if core is already doing it

$.Callbacks fire syncronously

Change-Id: Icb83c9fdd6854c49098fc6779cef73a4459d7734
---
M resources/ext.postEdit.js
1 file changed, 10 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/PostEdit 
refs/changes/15/66315/1

diff --git a/resources/ext.postEdit.js b/resources/ext.postEdit.js
index f366724..465e04c 100644
--- a/resources/ext.postEdit.js
+++ b/resources/ext.postEdit.js
@@ -3,7 +3,7 @@
 ( function ( mw, $ ) {
        'use strict';
 
-       var div;
+       var div, showConfirmation;
 
        /**
         * @param {jQuery.Event|undefined} e
@@ -24,7 +24,7 @@
                }
        }
 
-       if ( mw.config.get( 'wgPostEdit' ) ) {
+       showConfirmation = function () {
                div = document.createElement( 'div' );
                div.className = 'postedit-container';
                div.innerHTML =
@@ -41,6 +41,14 @@
                        $( 'body' ).prepend( div );
                        setTimeout( removeConfirmation, 3000 );
                } );
+       };
+
+       mw.hooks( 'postEdit' ).add( function () {
+               showConfirmation = $.noop;
+       } );
+
+       if ( mw.config.get( 'wgPostEdit' ) ) {
+               showConfirmation();
        }
 
 }( mediaWiki, jQuery ) );

-- 
To view, visit https://gerrit.wikimedia.org/r/66315
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icb83c9fdd6854c49098fc6779cef73a4459d7734
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/PostEdit
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh <o...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to