Stefan.petrea has uploaded a new change for review.
https://gerrit.wikimedia.org/r/67010
Change subject: Fixing problem with cronjob
......................................................................
Fixing problem with cronjob
Change-Id: I99f085722e85b576e931c23bd0df2c118db98005
---
M pageviews_reports/lib/PageViews/Model/Sequential.pm
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/analytics/wikistats
refs/changes/10/67010/1
diff --git a/pageviews_reports/lib/PageViews/Model/Sequential.pm
b/pageviews_reports/lib/PageViews/Model/Sequential.pm
index 15669bf..d733b23 100644
--- a/pageviews_reports/lib/PageViews/Model/Sequential.pm
+++ b/pageviews_reports/lib/PageViews/Model/Sequential.pm
@@ -236,7 +236,9 @@
}elsif( index($path_fragment,"w/index.php" ,0)!=-1) {
$retval->{"pageview-type"} = "wiki_index";
}elsif( index($path_fragment,"w/api.php" ,0)!=-1) {
- my $url_params = { split(/&|=/,$c[8]) };
+ my @kv = split(/&|=/,$c[8]);
+ return undef if(~~@kv % 2 == 1);
+ my $url_params = { @kv };
$retval->{"pageview-type"} = "api";
$retval->{action} = $url_params->{action};
$retval->{"title"} = $url_params->{page} ||
@@ -350,7 +352,7 @@
my ($self,$mime_type) = @_;
## text/html mime types only
## (mimetype filtering only occurs for regular pageviews, not for the API
ones)
- if( $mime_type =~ m{text/html|text/vnd\.wap\.wml|application/json}i ) {
+ if(defined($mime_type) && $mime_type =~
m{text/html|text/vnd\.wap\.wml|application/json}i ) {
return 1;
};
$self->{counts_discarded_mimetype}->{$self->{last_ymd}}++;
--
To view, visit https://gerrit.wikimedia.org/r/67010
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I99f085722e85b576e931c23bd0df2c118db98005
Gerrit-PatchSet: 1
Gerrit-Project: analytics/wikistats
Gerrit-Branch: master
Gerrit-Owner: Stefan.petrea <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
