jenkins-bot has submitted this change and it was merged. Change subject: Scroll to viewport after input methods list is rendered ......................................................................
Scroll to viewport after input methods list is rendered Added input methods may increase the height of window. Make sure the entire window is in view port. Bug: 49427 Change-Id: I06194b7d51459a31247104b2113ef3212774f004 --- M resources/js/ext.uls.inputsettings.js 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Nikerabbit: Looks good to me, approved jenkins-bot: Verified diff --git a/resources/js/ext.uls.inputsettings.js b/resources/js/ext.uls.inputsettings.js index ec525ca..de1a5f3 100644 --- a/resources/js/ext.uls.inputsettings.js +++ b/resources/js/ext.uls.inputsettings.js @@ -158,6 +158,10 @@ $imeListContainer.append( inputSettings.renderInputmethodOption( 'system', defaultInputmethod === 'system' ) ); + + // Added input methods may increase the height of window. Make sure + // the entire window is in view port + this.$parent.position(); }, renderInputmethodOption: function ( imeId, selected ) { -- To view, visit https://gerrit.wikimedia.org/r/68134 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I06194b7d51459a31247104b2113ef3212774f004 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector Gerrit-Branch: master Gerrit-Owner: Santhosh <santhosh.thottin...@gmail.com> Gerrit-Reviewer: KartikMistry <kartik.mis...@gmail.com> Gerrit-Reviewer: Nikerabbit <niklas.laxst...@gmail.com> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits