Jeroen De Dauw has submitted this change and it was merged.
Change subject: Fix string length check in StringValidator.
......................................................................
Fix string length check in StringValidator.
Unit tests for validators are still missing.
No point in adding them now with a redesign imminent,
but we should really have them soon.
Change-Id: I92e2b7cb98203119455ec91bfb5096a06dbe7fa1
---
M ValueValidators/includes/validators/StringValidator.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jeroen De Dauw: Looks good to me, approved
jenkins-bot: Verified
diff --git a/ValueValidators/includes/validators/StringValidator.php
b/ValueValidators/includes/validators/StringValidator.php
index 0fcd394..fa876ee 100644
--- a/ValueValidators/includes/validators/StringValidator.php
+++ b/ValueValidators/includes/validators/StringValidator.php
@@ -64,7 +64,7 @@
if ( $lowerBound !== false || $upperBound !== false ) {
$rangeValidator = new RangeValidator();
$rangeValidator->setRange( $lowerBound, $upperBound );
- $this->runSubValidator( count( $value ),
$rangeValidator, 'length' );
+ $this->runSubValidator( strlen( $value ),
$rangeValidator, 'length' );
}
// TODO: this needs tests
--
To view, visit https://gerrit.wikimedia.org/r/67956
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I92e2b7cb98203119455ec91bfb5096a06dbe7fa1
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/DataValues
Gerrit-Branch: master
Gerrit-Owner: Daniel Kinzler <daniel.kinz...@wikimedia.de>
Gerrit-Reviewer: Daniel Werner <daniel.wer...@wikimedia.de>
Gerrit-Reviewer: Jeroen De Dauw <jeroended...@gmail.com>
Gerrit-Reviewer: Tobias Gritschacher <tobias.gritschac...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
