jenkins-bot has submitted this change and it was merged.
Change subject: Travis + @test Settings::newFromGlobals Part III
......................................................................
Travis + @test Settings::newFromGlobals Part III
Change-Id: I0f96cc05169aed643abbb711e9ff52c194f39dcc
---
M tests/phpunit/includes/SettingsTest.php
1 file changed, 1 insertion(+), 3 deletions(-)
Approvals:
Mwjames: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/phpunit/includes/SettingsTest.php
b/tests/phpunit/includes/SettingsTest.php
index 9507264..963e584 100644
--- a/tests/phpunit/includes/SettingsTest.php
+++ b/tests/phpunit/includes/SettingsTest.php
@@ -174,9 +174,7 @@
$this->assertTrue( $instance !== Settings::newFromGlobals() );
foreach ( $settings as $key => $value ) {
- if ( isset( $GLOBALS[$key] ) ) {
- $this->assertEquals( $GLOBALS[$key],
$instance->get( $key ) );
- }
+ $this->assertEquals( $GLOBALS[$key], $instance->get(
$key ), "Failed asserting that {$key} exists" );
}
}
}
--
To view, visit https://gerrit.wikimedia.org/r/69085
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I0f96cc05169aed643abbb711e9ff52c194f39dcc
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/SemanticMediaWiki
Gerrit-Branch: master
Gerrit-Owner: Mwjames <[email protected]>
Gerrit-Reviewer: Mwjames <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
