jenkins-bot has submitted this change and it was merged.
Change subject: ve.ce.BranchNode: Use DOM rather than jQuery in #onSplice
......................................................................
ve.ce.BranchNode: Use DOM rather than jQuery in #onSplice
Change-Id: I75337048e9ae81c95333da5c0277dbf7dc562b1c
---
M modules/ve/ce/ve.ce.BranchNode.js
1 file changed, 17 insertions(+), 3 deletions(-)
Approvals:
Krinkle: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/ve/ce/ve.ce.BranchNode.js
b/modules/ve/ce/ve.ce.BranchNode.js
index 6704aa4..c6d6050 100644
--- a/modules/ve/ce/ve.ce.BranchNode.js
+++ b/modules/ve/ce/ve.ce.BranchNode.js
@@ -149,10 +149,14 @@
* @param {ve.dm.BranchNode...} [nodes] Variadic list of nodes to insert
*/
ve.ce.BranchNode.prototype.onSplice = function ( index ) {
- var i,
+ var i, j,
length,
args = Array.prototype.slice.call( arguments ),
$anchor,
+ afterAnchor,
+ node,
+ parentNode,
+ firstChild,
removals;
// Convert models to views and attach them to this node
if ( args.length >= 3 ) {
@@ -176,9 +180,19 @@
for ( i = args.length - 1; i >= 2; i-- ) {
args[i].attach( this );
if ( index ) {
- $anchor.after( args[i].$ );
+ // DOM equivalent of $anchor.after( args[i].$ );
+ afterAnchor = $anchor[0].nextSibling;
+ parentNode = $anchor[0].parentNode;
+ for ( j = 0, length = args[i].$.length; j <
length; j++ ) {
+ parentNode.insertBefore( args[i].$[j],
afterAnchor );
+ }
} else {
- this.$.prepend( args[i].$ );
+ // DOM equivalent of this.$.prepend( args[j].$
);
+ node = this.$[0];
+ firstChild = node.firstChild;
+ for ( j = args[i].$.length - 1; j >= 0; j-- ) {
+ node.insertBefore( args[i].$[j],
firstChild );
+ }
}
if ( this.live !== args[i].isLive() ) {
args[i].setLive( this.live );
--
To view, visit https://gerrit.wikimedia.org/r/69763
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I75337048e9ae81c95333da5c0277dbf7dc562b1c
Gerrit-PatchSet: 5
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Catrope <roan.katt...@gmail.com>
Gerrit-Reviewer: Catrope <roan.katt...@gmail.com>
Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
