Subramanya Sastry has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/70091


Change subject: (Bug 49929) Fixed bad regexps in wikitext escaping
......................................................................

(Bug 49929) Fixed bad regexps in wikitext escaping

* Examples in the bug report are all fixed.
* TODO: Add more parser tests.

Change-Id: I925d8ded2da16e0bd107fde77d58beff2aac3782
---
M js/lib/mediawiki.WikitextSerializer.js
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Parsoid 
refs/changes/91/70091/1

diff --git a/js/lib/mediawiki.WikitextSerializer.js 
b/js/lib/mediawiki.WikitextSerializer.js
index 05ecbe5..ff04346 100644
--- a/js/lib/mediawiki.WikitextSerializer.js
+++ b/js/lib/mediawiki.WikitextSerializer.js
@@ -571,7 +571,7 @@
        // Quick check for the common case (useful to kill a majority of 
requests)
        //
        // Pure white-space or text without wt-special chars need not be 
analyzed
-       if (!fullCheckNeeded && !text.match(/^[ 
\t][^\s]+|[<>\[\]\-\+\|'!=#\*:;~{}]/)) {
+       if (!fullCheckNeeded && !text.match(/^[ 
\t]+[^\s]+|[<>\[\]\-\+\|'!=#\*:;~{}]/)) {
                // console.warn("---EWT:F1---");
                return text;
        }
@@ -620,7 +620,7 @@
        // SSS FIXME: pre-escaping is currently broken since the front-end 
parser
        // eliminated pre-tokens in the tokenizer and moved to a stream handler.
        // So, we always conservatively escape text with ' ' in sol posn.
-       if (sol && text.match(/(^ |\n )[^\s]+/)) {
+       if (sol && text.match(/(^[ \t]+|\n[ \t]+)[^\s]+/)) {
                // console.warn("---EWT:F6---");
                return escapedText(text);
        }

-- 
To view, visit https://gerrit.wikimedia.org/r/70091
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I925d8ded2da16e0bd107fde77d58beff2aac3782
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Parsoid
Gerrit-Branch: master
Gerrit-Owner: Subramanya Sastry <ssas...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to