jenkins-bot has submitted this change and it was merged. Change subject: mw.ViewPageTarget: Blacklist IE9/IE10 until blocking issues are resolved ......................................................................
mw.ViewPageTarget: Blacklist IE9/IE10 until blocking issues are resolved Bug: 49187 Change-Id: I2ee2e33c89cac58863c9911fc3ad250c72a46206 --- M modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js M modules/ve/test/init/mw/targets/ve.init.mw.ViewPageTarget.test.js 2 files changed, 8 insertions(+), 5 deletions(-) Approvals: Catrope: Looks good to me, approved jenkins-bot: Verified diff --git a/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js b/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js index e6cf949..4e76876 100644 --- a/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js +++ b/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js @@ -185,14 +185,17 @@ // The value is either null (match all versions) or a list of tuples // containing an inequality (<,>,<=,>=) and a version number 'whitelist': { - 'msie': [['>=', 9]], 'firefox': [['>=', 11]], 'iceweasel': [['>=', 10]], 'safari': [['>=', 5]], 'chrome': [['>=', 19]] }, 'blacklist': { - 'msie': [['<', 9]], + // IE <= 8 has various incompatibilities in layout and feature support + // IE9 and IE10 generally work but fail in ajax handling when making POST + // requests to the VisualEditor/Parsoid API which is causing silent failures + // when trying to save a page (bug 49187) + 'msie': [['<=', 10]], 'android': [['<', 3]], // Blacklist all versions: 'opera': null, diff --git a/modules/ve/test/init/mw/targets/ve.init.mw.ViewPageTarget.test.js b/modules/ve/test/init/mw/targets/ve.init.mw.ViewPageTarget.test.js index 9afebab..aceccdb 100644 --- a/modules/ve/test/init/mw/targets/ve.init.mw.ViewPageTarget.test.js +++ b/modules/ve/test/init/mw/targets/ve.init.mw.ViewPageTarget.test.js @@ -28,12 +28,12 @@ { 'msg': 'IE9', 'userAgent': 'Mozilla/5.0 (Windows; U; MSIE 9.0; Windows NT 9.0; en-US)', - 'matches': [ 'whitelist' ] + 'matches': [ 'blacklist' ] }, { 'msg': 'IE10', 'userAgent': 'Mozilla/5.0 (compatible; MSIE 10.0; Windows NT 6.1; WOW64; Trident/6.0)', - 'matches': [ 'whitelist' ] + 'matches': [ 'blacklist' ] }, { 'msg': 'Firefox 10', @@ -134,4 +134,4 @@ assert.deepEqual( matches, cases[i].matches, cases[i].msg + ': ' + ( cases[i].matches.length ? cases[i].matches.join() : 'greylist (no matches)' ) ); } -} ); \ No newline at end of file +} ); -- To view, visit https://gerrit.wikimedia.org/r/70108 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I2ee2e33c89cac58863c9911fc3ad250c72a46206 Gerrit-PatchSet: 4 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Krinkle <krinklem...@gmail.com> Gerrit-Reviewer: Catrope <roan.katt...@gmail.com> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits