[MediaWiki-commits] [Gerrit] Make Selenium tests aware of timeout when parsing time inputs - change (mediawiki...Wikibase)

[Tobias Gritschacher (Code Review)]

Tobias Gritschacher has submitted this change and it was merged.

Change subject: Make Selenium tests aware of timeout when parsing time inputs
......................................................................


Make Selenium tests aware of timeout when parsing time inputs

Change-Id: I9eefde35bb8875394f338131b90dbc890c6fe98e
---
M repo/tests/selenium/statements/statements_time_spec.rb
M selenium/lib/modules/time_module.rb
2 files changed, 8 insertions(+), 0 deletions(-)

Approvals:
  Tobias Gritschacher: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/repo/tests/selenium/statements/statements_time_spec.rb 
b/repo/tests/selenium/statements/statements_time_spec.rb
index 3536a9d..1809672 100644
--- a/repo/tests/selenium/statements/statements_time_spec.rb
+++ b/repo/tests/selenium/statements/statements_time_spec.rb
@@ -217,6 +217,8 @@
         page.wait_for_entity_selector_list
         page.wait_for_property_value_box
         page.statementValueInputField = time_values[0]["input"]
+        page.wait_for_time_request
+        ajax_wait
         page.saveStatement?.should be_true
         page.saveStatement
         ajax_wait
diff --git a/selenium/lib/modules/time_module.rb 
b/selenium/lib/modules/time_module.rb
index f7c3eda..8d0c80b 100644
--- a/selenium/lib/modules/time_module.rb
+++ b/selenium/lib/modules/time_module.rb
@@ -64,4 +64,10 @@
       self.timePrecision_element.when_visible
     end
   end
+
+  def wait_for_time_request
+    wait_until do
+      previewSpinner? == false
+    end
+  end
 end

-- 
To view, visit https://gerrit.wikimedia.org/r/70396
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9eefde35bb8875394f338131b90dbc890c6fe98e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Tobias Gritschacher <tobias.gritschac...@wikimedia.de>
Gerrit-Reviewer: Tobias Gritschacher <tobias.gritschac...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits