Faidon has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/70414


Change subject: Fix decomissioning
......................................................................

Fix decomissioning

Commit de4926d3 silently changed all decomissioning.pp's double quotes
to single quotes, which broke the decomissioning shell script that
parses that. Adjust the shell script to only handle single quotes now.

Change-Id: I7acd666ef5abf76b3e6ee21b359bca283a565ac8
---
M templates/puppet/decom_servers.sh.erb
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/14/70414/1

diff --git a/templates/puppet/decom_servers.sh.erb 
b/templates/puppet/decom_servers.sh.erb
index 0cede89..8a82587 100644
--- a/templates/puppet/decom_servers.sh.erb
+++ b/templates/puppet/decom_servers.sh.erb
@@ -6,7 +6,7 @@
 
 export PATH
 
-for srv in $(cut -d'"' -f 2 -s <%= 
scope.lookupvar('puppetmaster::config::gitdir') 
%>/operations/puppet/manifests/decommissioning.pp)
+for srv in $(cut -d"'" -f 2 -s <%= 
scope.lookupvar('puppetmaster::config::gitdir') 
%>/operations/puppet/manifests/decommissioning.pp)
        do puppetstoredconfigclean.rb $srv.wikimedia.org 
$srv.esams.wikimedia.org $srv.pmtpa.wmnet $srv.eqiad.wmnet > /dev/null
 done
 

-- 
To view, visit https://gerrit.wikimedia.org/r/70414
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7acd666ef5abf76b3e6ee21b359bca283a565ac8
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Faidon <fai...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to