Ryan Lane has submitted this change and it was merged. Change subject: Fix some Echo-related messages ......................................................................
Fix some Echo-related messages It seems some changes have been made to how these messages are used in Echo They are now phrased differently and can be used for enabling/disabling web notifications as well as email notifications. Change-Id: Iac6d60b3de463a904f1b04aa46027a74c662a981 --- M OpenStackManager.i18n.php 1 file changed, 7 insertions(+), 7 deletions(-) Approvals: Ryan Lane: Verified; Looks good to me, approved jenkins-bot: Checked diff --git a/OpenStackManager.i18n.php b/OpenStackManager.i18n.php index 20279f8..6b1d4d8 100644 --- a/OpenStackManager.i18n.php +++ b/OpenStackManager.i18n.php @@ -433,9 +433,9 @@ 'notification-osm-instance-build-completed' => '$1 {{GENDER:$1|built}} instance \'$3\' in project [[$2]]', 'notification-osm-instance-reboot-completed' => '$1 {{GENDER:$1|rebooted}} instance \'$3\' in project [[$2]]', 'notification-osm-projectmember-added' => '$1 {{GENDER:$1|added}} you to project [[$2]]', - 'echo-category-title-osm-instance-deleted' => 'Deletes an instance from a project I\'m an admin on.', - 'echo-category-title-osm-instance-build-completed' => 'Builds an instance on a project I\'m an admin on.', - 'echo-category-title-osm-instance-reboot-completed' => 'Reboots an instance.', + 'echo-category-title-osm-instance-deleted' => 'Instance deletion (where you are project admin)', + 'echo-category-title-osm-instance-build-completed' => 'Instance build (where you are project admin)', + 'echo-category-title-osm-instance-reboot-completed' => 'Instance reboot completion', 'echo-category-title-osm-projectmembers-add' => 'Project membership addition', 'prefs-openstack' => 'OpenStack', @@ -1475,14 +1475,14 @@ 'notification-osm-projectmember-added' => 'Title for the new project membership notification. * $1 - agent * $2 - project', - 'echo-category-title-osm-instance-deleted' => 'Used by the Echo extension in the Preferences -> Notifications tab as a label to enable email notification for the osm-instance-deleted event. + 'echo-category-title-osm-instance-deleted' => 'Used by the Echo extension in the Preferences -> Notifications tab as a label to enable notifications for the osm-instance-deleted event. Preceded by {{msg-mw|Prefs-emailsubscriptions}}.', - 'echo-category-title-osm-instance-build-completed' => 'Used by the Echo extension in the Preferences -> Notifications tab as a label to enable email notification for the osm-instance-build-completed event. + 'echo-category-title-osm-instance-build-completed' => 'Used by the Echo extension in the Preferences -> Notifications tab as a label to enable notifications for the osm-instance-build-completed event. Preceded by {{msg-mw|Prefs-emailsubscriptions}}.', - 'echo-category-title-osm-instance-reboot-completed' => 'Used by the Echo extension in the Preferences -> Notifications tab as a label to enable email notification for the osm-instance-reboot-completed event.', - 'echo-category-title-osm-projectmembers-add' => 'Used by the Echo extension in the Preferences -> Notifications tab as a label to enable email notification for the osm-projectmember-add event.', + 'echo-category-title-osm-instance-reboot-completed' => 'Used by the Echo extension in the Preferences -> Notifications tab as a label to enable notifications for the osm-instance-reboot-completed event.', + 'echo-category-title-osm-projectmembers-add' => 'Used by the Echo extension in the Preferences -> Notifications tab as a label to enable notifications for the osm-projectmember-add event.', 'prefs-openstack' => 'Title for a tab in Preferences for OpenStack related items', 'prefs-openstack-keys' => 'Subheading used in the Preferences -> OpenStack for a the public SSH key list', ); -- To view, visit https://gerrit.wikimedia.org/r/70046 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Iac6d60b3de463a904f1b04aa46027a74c662a981 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/OpenStackManager Gerrit-Branch: master Gerrit-Owner: Alex Monk <kren...@gmail.com> Gerrit-Reviewer: Ryan Lane <rl...@wikimedia.org> Gerrit-Reviewer: Siebrand <siebr...@wikimedia.org> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits