Cmcmahon has submitted this change and it was merged.
Change subject: Fixed failing login test
......................................................................
Fixed failing login test
Tested at test2.wikipedia.org and en.wikipedia.beta.wmflabs.org.
Bug: 50130
Change-Id: I6467cd14ce6a193c45a803c6798c176dcc7a444a
---
M features/step_definitions/login_steps.rb
M features/support/pages/login_page.rb
2 files changed, 2 insertions(+), 1 deletion(-)
Approvals:
Cmcmahon: Looks good to me, approved
jenkins-bot: Verified
diff --git a/features/step_definitions/login_steps.rb
b/features/step_definitions/login_steps.rb
index 82e8aa6..4d8190b 100644
--- a/features/step_definitions/login_steps.rb
+++ b/features/step_definitions/login_steps.rb
@@ -34,7 +34,7 @@
on(LoginPage).password_element.should exist
end
Then(/^there should be text (.+)$/) do |text|
- @browser.text.should match Regexp.escape(text)
+ on(LoginPage).username_displayed_element.when_present.text.should == text
end
Then(/^Username element should be there$/) do
on(LoginPage).username_element.should exist
diff --git a/features/support/pages/login_page.rb
b/features/support/pages/login_page.rb
index 5a22322..2ae316f 100644
--- a/features/support/pages/login_page.rb
+++ b/features/support/pages/login_page.rb
@@ -10,6 +10,7 @@
a(:phishing, text: 'phishing')
a(:password_strength, text: 'password strength')
text_field(:username, id: 'wpName1')
+ a(:username_displayed, title: "Your user page [ctrl-option-.]")
def logged_in_as_element
@browser.div(id: 'mw-content-text').p.b
--
To view, visit https://gerrit.wikimedia.org/r/70639
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6467cd14ce6a193c45a803c6798c176dcc7a444a
Gerrit-PatchSet: 1
Gerrit-Project: qa/browsertests
Gerrit-Branch: master
Gerrit-Owner: Zfilipin <zfili...@wikimedia.org>
Gerrit-Reviewer: Cmcmahon <cmcma...@wikimedia.org>
Gerrit-Reviewer: Rachel99 <rachelq...@gmail.com>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
