Catrope has uploaded a new change for review. https://gerrit.wikimedia.org/r/71551
Change subject: Per its own documentation, make showMessage()'s wrap default to 'warning' ...................................................................... Per its own documentation, make showMessage()'s wrap default to 'warning' This was producing some lovely <visualeditor-savedialog-label-undefined> garbage. Change-Id: I0852fea9088738d9a93e25bd3b104b9aa07c256d --- M modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js 1 file changed, 3 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor refs/changes/51/71551/1 diff --git a/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js b/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js index eb29d5c..3939500 100644 --- a/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js +++ b/modules/ve/init/mw/targets/ve.init.mw.ViewPageTarget.js @@ -2190,6 +2190,9 @@ var $message; if ( !this.messages[name] ) { options = options || {}; + if ( options.wrap === undefined ) { + options.wrap = 'warning'; + } $message = $( '<div class="ve-init-mw-viewPageTarget-saveDialog-message"></div>' ); if ( options.wrap !== false ) { $message.append( $( '<p>').append( -- To view, visit https://gerrit.wikimedia.org/r/71551 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0852fea9088738d9a93e25bd3b104b9aa07c256d Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Catrope <roan.katt...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits