Aude has uploaded a new change for review.
https://gerrit.wikimedia.org/r/72090
Change subject: (bug 50798) Allow dynamic site link group section headings in
item view
......................................................................
(bug 50798) Allow dynamic site link group section headings in item view
Change-Id: Ibd63ad8b5f1d90628151412deacfe89e7dc94822
---
M lib/resources/templates.php
M repo/includes/ItemView.php
M repo/resources/Resources.php
M repo/resources/wikibase.ui.entityViewInit.js
4 files changed, 16 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/90/72090/1
diff --git a/lib/resources/templates.php b/lib/resources/templates.php
index 70a6ad8..3924e65 100644
--- a/lib/resources/templates.php
+++ b/lib/resources/templates.php
@@ -46,6 +46,11 @@
<h2 class="wb-section-heading" dir="auto" id="$2">$1</h2>
HTML;
+ $templates['wb-section-sitelink-heading'] =
+<<<HTML
+<h2 class="wb-section-heading $3" dir="auto" id="$2">$1</h2>
+HTML;
+
$templates['wb-claimlist'] =
<<<HTML
<div class="wb-claimlist">
diff --git a/repo/includes/ItemView.php b/repo/includes/ItemView.php
index 5429f14..48b4d74 100644
--- a/repo/includes/ItemView.php
+++ b/repo/includes/ItemView.php
@@ -90,9 +90,10 @@
$html = $thead = $tbody = $tfoot = '';
$html .= wfTemplate(
- 'wb-section-heading',
+ 'wb-section-sitelink-heading',
wfMessage( 'wikibase-sitelinks-' . $group )->parse(),
// heading
- htmlspecialchars( 'sitelinks-' . $group, ENT_QUOTES )
// ID
+ htmlspecialchars( 'sitelinks-' . $group, ENT_QUOTES ),
// ID
+ 'wb-sitelink-heading'
// TODO: support entity-id as prefix for element IDs.
);
diff --git a/repo/resources/Resources.php b/repo/resources/Resources.php
index b3daed2..37623ba 100644
--- a/repo/resources/Resources.php
+++ b/repo/resources/Resources.php
@@ -53,7 +53,6 @@
'wikibase.serialization.fetchedcontent'
),
'messages' => array(
- 'wikibase-sitelinks-wikipedia',
'wikibase-statements',
'wikibase-copyrighttooltip-acknowledge',
'wikibase-anonymouseditwarning',
diff --git a/repo/resources/wikibase.ui.entityViewInit.js
b/repo/resources/wikibase.ui.entityViewInit.js
index 8228eea..7c9f54a 100644
--- a/repo/resources/wikibase.ui.entityViewInit.js
+++ b/repo/resources/wikibase.ui.entityViewInit.js
@@ -107,6 +107,13 @@
new wb.ui.AliasesEditTool( this );
} );
+ // store site link section heading text for js entity
view
+ var siteLinkHeadings = [];
+
+ $( '.wb-sitelink-heading' ).each( function( i ) {
+ siteLinkHeadings[$( this ).attr( 'id' )] = $(
this ).text();
+ });
+
$( '.wb-section-heading' ).remove();
// BUILD CLAIMS VIEW:
@@ -133,7 +140,7 @@
$( this ).before(
mw.template(
'wb-section-heading',
- mw.msg( 'wikibase-sitelinks-' +
group ),
+ siteLinkHeadings['sitelinks-' +
group],
'sitelinks'
).append( $sitesCounterContainer )
);
--
To view, visit https://gerrit.wikimedia.org/r/72090
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibd63ad8b5f1d90628151412deacfe89e7dc94822
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Aude <aude.w...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
