Cmcmahon has submitted this change and it was merged.
Change subject: Removed page-object gem deprecation warnings
......................................................................
Removed page-object gem deprecation warnings
Bug: 46893
Change-Id: I6e5a39319265f4d8163dd3dccec10cbf627093f6
---
M features/step_definitions/math_steps.rb
M features/step_definitions/visual_editor_references_steps.rb
M features/step_definitions/visual_editor_steps.rb
M features/step_definitions/visual_editor_transclusion_steps.rb
M features/support/pages/article_page.rb
5 files changed, 8 insertions(+), 9 deletions(-)
Approvals:
Cmcmahon: Looks good to me, approved
jenkins-bot: Verified
diff --git a/features/step_definitions/math_steps.rb
b/features/step_definitions/math_steps.rb
index 1994ba5..efacb0e 100644
--- a/features/step_definitions/math_steps.rb
+++ b/features/step_definitions/math_steps.rb
@@ -17,9 +17,9 @@
end
Then(/^alt for that img should be (.+)$/) do |alt|
- on(EditPage).math_image_element.alt.should == alt
+ on(EditPage).math_image_element.element.alt.should == alt
end
Then(/^src for that img should come from (.+)$/) do |src|
- on(EditPage).math_image_element.src.should match Regexp.escape(src)
+ on(EditPage).math_image_element.element.src.should match Regexp.escape(src)
end
diff --git a/features/step_definitions/visual_editor_references_steps.rb
b/features/step_definitions/visual_editor_references_steps.rb
index 40fb282..52e420a 100644
--- a/features/step_definitions/visual_editor_references_steps.rb
+++ b/features/step_definitions/visual_editor_references_steps.rb
@@ -16,7 +16,7 @@
end
When(/^I enter (.+) into Content box$/) do |content|
- on(VisualEditorPage).content_box_element.wait_until_present
+ on(VisualEditorPage).content_box_element.when_present
on(VisualEditorPage).content_box=content
end
diff --git a/features/step_definitions/visual_editor_steps.rb
b/features/step_definitions/visual_editor_steps.rb
index 541c40b..33278ed 100644
--- a/features/step_definitions/visual_editor_steps.rb
+++ b/features/step_definitions/visual_editor_steps.rb
@@ -22,8 +22,7 @@
When(/^I click Save page$/) do
on(VisualEditorPage) do |page|
- sleep 2 # blame Chris for this!
- page.save_disabled_element.wait_while_present
+ sleep 2 # blame Chris for this!
page.save_page_element.when_present.click
end
end
@@ -41,7 +40,7 @@
When(/^I click Return to save form$/) do
on(VisualEditorPage) do |page|
- page.diff_view_element.wait_until_present
+ page.diff_view_element.when_present
page.return_to_save_element.when_present.click
end
end
diff --git a/features/step_definitions/visual_editor_transclusion_steps.rb
b/features/step_definitions/visual_editor_transclusion_steps.rb
index 6ac18bb..c75bcef 100644
--- a/features/step_definitions/visual_editor_transclusion_steps.rb
+++ b/features/step_definitions/visual_editor_transclusion_steps.rb
@@ -33,7 +33,7 @@
When(/^I enter (.+) in the parameter box$/) do |param_value|
on(VisualEditorPage) do |page|
- page.parameter_box_element.wait_until_present
+ page.parameter_box_element.when_present
page.parameter_box=param_value
end
end
@@ -55,4 +55,4 @@
Then(/^I should see the Apply changes button$/) do
on(VisualEditorPage).apply_changes_element.when_present.should be_visible
-end
\ No newline at end of file
+end
diff --git a/features/support/pages/article_page.rb
b/features/support/pages/article_page.rb
index 330f75f..9c27876 100644
--- a/features/support/pages/article_page.rb
+++ b/features/support/pages/article_page.rb
@@ -5,7 +5,7 @@
page_url URL.url('<%=params[:page_name]%>')
a(:actions_link) do |page|
- page.actions_element.a
+ page.actions_element.element.a
end
div(:actions, id: 'p-cactions')
a(:discussion, text: 'Discussion')
--
To view, visit https://gerrit.wikimedia.org/r/74091
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6e5a39319265f4d8163dd3dccec10cbf627093f6
Gerrit-PatchSet: 2
Gerrit-Project: qa/browsertests
Gerrit-Branch: master
Gerrit-Owner: Plavi <[email protected]>
Gerrit-Reviewer: Cmcmahon <[email protected]>
Gerrit-Reviewer: Zfilipin <[email protected]>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
