Mooeypoo has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/74835


Change subject: RTL Fix for Category Popup
......................................................................

RTL Fix for Category Popup

Flipped the generated positions of the MWCategoryPopupWidget in case
the GUI is RTL.

Bug: 51490
Change-Id: I83436d50a4a0596fdae9526c3fc2804cf880a530
---
M modules/ve-mw/ui/widgets/ve.ui.MWCategoryPopupWidget.js
1 file changed, 9 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/35/74835/1

diff --git a/modules/ve-mw/ui/widgets/ve.ui.MWCategoryPopupWidget.js 
b/modules/ve-mw/ui/widgets/ve.ui.MWCategoryPopupWidget.js
index 911ad37..1ad1944 100644
--- a/modules/ve-mw/ui/widgets/ve.ui.MWCategoryPopupWidget.js
+++ b/modules/ve-mw/ui/widgets/ve.ui.MWCategoryPopupWidget.js
@@ -173,6 +173,14 @@
                width = this.$menu.outerWidth( true ),
                height = this.$menu.outerHeight( true );
 
-       this.$.css( { 'left': left, 'top': top } );
+       if ( this.$container.attr('dir') === 'rtl' ) {
+               //flip me, I'm a mirror:
+               this.$.css( {
+                       'right': this.$container.outerWidth( true ) - left,
+                       'top': top
+               } );
+       } else {
+               this.$.css( { 'left': left, 'top': top } );
+       }
        this.display( left, top, width, height );
 };

-- 
To view, visit https://gerrit.wikimedia.org/r/74835
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I83436d50a4a0596fdae9526c3fc2804cf880a530
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Mooeypoo <mor...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to