jenkins-bot has submitted this change and it was merged.
Change subject: Fix instantiation issue in DataValueFactory and add deprecation
notice
......................................................................
Fix instantiation issue in DataValueFactory and add deprecation notice
Change-Id: I4441adc0bed77a892f7f3ff1de9c5c1a0afc92bd
---
M DataValues/includes/DataValueFactory.php
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Denny Vrandecic: Looks good to me, approved
jenkins-bot: Verified
diff --git a/DataValues/includes/DataValueFactory.php
b/DataValues/includes/DataValueFactory.php
index e2ace8d..5ef01aa 100644
--- a/DataValues/includes/DataValueFactory.php
+++ b/DataValues/includes/DataValueFactory.php
@@ -41,10 +41,11 @@
*
* @var string[]
*/
- protected $values;
+ protected $values = array();
/**
* Singleton.
+ * @deprecated Create your own instance rather then relying on global
state
*
* @since 0.1
*
--
To view, visit https://gerrit.wikimedia.org/r/74635
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4441adc0bed77a892f7f3ff1de9c5c1a0afc92bd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DataValues
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <jeroended...@gmail.com>
Gerrit-Reviewer: Denny Vrandecic <denny.vrande...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
