Rillke has uploaded a new change for review.
https://gerrit.wikimedia.org/r/75083
Change subject: Adding important to overflow:auto on scrollable elements
......................................................................
Adding important to overflow:auto on scrollable elements
Some CSS rules in VisualEditor also contain definitions for overflow.
Because their selectors are sometimes more specific, they overwrite the
overflow property set by matching .ve-ui-panelLayout-scrollable (e.g. as
reported in bug 51793).
Since making elements scrollable is done explicitly by adding this class
(ve-ui-panelLayout-scrollable) to elements, there is no harm in putting
!important behind the CSS's value to ensure it is never overwritten.
If an exception rule would be wanted for horizontal scrolling, it could still be
implemented like:
.ve-ui-panelLayout-scrollable.ve-ui-panelLayout-hscrollable {
overflow-x: auto !important;
overflow-y: hidden !important;
}
However, I would simply suggest making an independent class for
horizontal scrolling, if required.
Bug: 51793
Change-Id: I3b6d457616e7517da1b2326b1c59199f9267afff
---
M modules/ve/ui/styles/ve.ui.Layout.css
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/83/75083/1
diff --git a/modules/ve/ui/styles/ve.ui.Layout.css
b/modules/ve/ui/styles/ve.ui.Layout.css
index c532348..0311b40 100644
--- a/modules/ve/ui/styles/ve.ui.Layout.css
+++ b/modules/ve/ui/styles/ve.ui.Layout.css
@@ -18,7 +18,7 @@
}
.ve-ui-panelLayout-scrollable {
- overflow-y: auto;
+ overflow-y: auto !important;
}
.ve-ui-panelLayout-padded {
--
To view, visit https://gerrit.wikimedia.org/r/75083
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3b6d457616e7517da1b2326b1c59199f9267afff
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Rillke <rainerril...@hotmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
