Addshore has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/75321


Change subject: Do not store empty aliases in the datamodel
......................................................................

Do not store empty aliases in the datamodel

Bug: 51811
Change-Id: I9d88489da21da12c6e2ae191ea065376daae6253
---
M DataModel/Entity/Entity.php
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseDataModel 
refs/changes/21/75321/1

diff --git a/DataModel/Entity/Entity.php b/DataModel/Entity/Entity.php
index fa36c53..64a079c 100644
--- a/DataModel/Entity/Entity.php
+++ b/DataModel/Entity/Entity.php
@@ -359,6 +359,7 @@
         * @param array $aliases
         */
        public function setAliases( $languageCode, array $aliases ) {
+               $aliases = array_diff( $aliases, array( '' ) );
                $aliases = array_values( array_unique( $aliases ) );
                if( count( $aliases ) > 0 ) {
                        $this->data['aliases'][$languageCode] = $aliases;

-- 
To view, visit https://gerrit.wikimedia.org/r/75321
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9d88489da21da12c6e2ae191ea065376daae6253
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseDataModel
Gerrit-Branch: master
Gerrit-Owner: Addshore <addshorew...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to