Santhosh has uploaded a new change for review. https://gerrit.wikimedia.org/r/75564
Change subject: Lazy initialization of language settings for IME menu ...................................................................... Lazy initialization of language settings for IME menu Initialize it only when first time user clicks on it In a page like Special:Translate where lot of input fields appearing, the previous approach was adding many language settings div to the page. Change-Id: If063df6782c6a51ac77ed5531dfa253c7f3ddbc4 --- M resources/js/ext.uls.ime.js 1 file changed, 11 insertions(+), 9 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UniversalLanguageSelector refs/changes/64/75564/1 diff --git a/resources/js/ext.uls.ime.js b/resources/js/ext.uls.ime.js index 8f16b81..786a474 100644 --- a/resources/js/ext.uls.ime.js +++ b/resources/js/ext.uls.ime.js @@ -121,18 +121,20 @@ $moreSettingsLink = $( '<span>' ) .addClass( 'uls-ime-more-settings-link' ); - $moreSettingsLink.languagesettings( { - defaultModule: 'input', - onClose: function () { - // on close of input settings, keep focus in input area. - imeselector.$element.focus(); - }, - top: imeselector.$element.offset().top - } ); - // Hide the menu. $moreSettingsLink.on( 'click', function ( e ) { + var languageSettings = $( this ).data( 'languagesettings' ); imeselector.hide(); + if ( !languageSettings ) { + $( this ).languagesettings( { + defaultModule: 'input', + onClose: function () { + // on close of input settings, keep focus in input area. + imeselector.$element.focus(); + }, + top: imeselector.$element.offset().top + } ).click(); + } e.stopPropagation(); } ); -- To view, visit https://gerrit.wikimedia.org/r/75564 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If063df6782c6a51ac77ed5531dfa253c7f3ddbc4 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector Gerrit-Branch: master Gerrit-Owner: Santhosh <santhosh.thottin...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits