Matmarex has uploaded a new change for review.
https://gerrit.wikimedia.org/r/75571
Change subject: Enhanced RC: Remove the list of users who edited the page
......................................................................
Enhanced RC: Remove the list of users who edited the page
* It can get unwieldy long for active discussion pages; 50 edits by 30
different users a day is not an uncommon occurence
* It's useless for short ones as well; this information is rarely
useful and always reduntant with what's available in the expandable
list.
While we're at it, fix the display for when $wgRCShowWatchingUsers is
enabled (it's off by default) and add closing </td></tr> tags for
"title" of enhanced changeslist row (but it worked fine without them).
Bug: 51895
Change-Id: I795d9c2853d65098b1831467d96b840aaf95a08c
---
M includes/ChangesList.php
M maintenance/dictionary/mediawiki.dic
M skins/common/oldshared.css
M skins/common/shared.css
4 files changed, 10 insertions(+), 43 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/71/75571/1
diff --git a/includes/ChangesList.php b/includes/ChangesList.php
index f3dcf67..eb6465a 100644
--- a/includes/ChangesList.php
+++ b/includes/ChangesList.php
@@ -882,8 +882,6 @@
$r = Html::openElement( 'table', array( 'class' => $classes ) )
.
Html::openElement( 'tr' );
- # Collate list of users
- $userlinks = array();
# Other properties
$unpatrolled = false;
$isnew = false;
@@ -904,9 +902,6 @@
$namehidden = false;
}
$u = $rcObj->userlink;
- if ( !isset( $userlinks[$u] ) ) {
- $userlinks[$u] = 0;
- }
if ( $rcObj->unpatrolled ) {
$unpatrolled = true;
}
@@ -928,27 +923,7 @@
if ( !$rcObj->mAttribs['rc_minor'] ) {
$allMinors = false;
}
-
- $userlinks[$u]++;
}
-
- # Sort the list and convert to text
- krsort( $userlinks );
- asort( $userlinks );
- $users = array();
- foreach ( $userlinks as $userlink => $count ) {
- $text = $userlink;
- $text .= $this->getLanguage()->getDirMark();
- if ( $count > 1 ) {
- $text .= ' ' . $this->msg( 'parentheses'
)->rawParams( $this->getLanguage()->formatNum( $count ) . '×' )->escaped();
- }
- array_push( $users, $text );
- }
-
- $users = ' <span class="changedby">'
- . $this->msg( 'brackets' )->rawParams(
- implode( $this->message['semicolon-separator'],
$users )
- )->escaped() . '</span>';
$tl = '<span class="mw-collapsible-toggle mw-collapsible-arrow
mw-enhancedchanges-arrow mw-enhancedchanges-arrow-space"></span>';
$r .= "<td>$tl</td>";
@@ -1027,8 +1002,6 @@
$r .= $this->msg( 'parentheses' )->rawParams( $logtext
)->escaped();
}
- $r .= ' <span class="mw-changeslist-separator">. .</span> ';
-
# Character difference (does not apply if only log items)
if ( $wgRCShowChangedSize && !$allLogs ) {
$last = 0;
@@ -1043,15 +1016,18 @@
# Get net change
$chardiff = $this->formatCharacterDifference(
$block[$first], $block[$last] );
- if ( $chardiff == '' ) {
- $r .= ' ';
- } else {
- $r .= ' ' . $chardiff . ' <span
class="mw-changeslist-separator">. .</span> ';
+ if ( $chardiff ) {
+ $r .= ' <span
class="mw-changeslist-separator">. .</span> ' . $chardiff;
}
}
- $r .= $users;
- $r .= $this->numberofWatchingusers(
$block[0]->numberofWatchingusers );
+ # This is not shown by default, see $wgRCShowWatchingUsers
+ $watchingUsers = $this->numberofWatchingusers(
$block[0]->numberofWatchingusers );
+ if ( $watchingUsers ) {
+ $r .= ' <span class="mw-changeslist-separator">.
.</span> ' . $watchingUsers;
+ }
+
+ $r .= '</td></tr>';
# Sub-entries
foreach ( $block as $rcObj ) {
diff --git a/maintenance/dictionary/mediawiki.dic
b/maintenance/dictionary/mediawiki.dic
index b86d2c5..df9f6bd 100644
--- a/maintenance/dictionary/mediawiki.dic
+++ b/maintenance/dictionary/mediawiki.dic
@@ -876,7 +876,6 @@
change's
changeablegroups
changed
-changedby
changedorcreated
changeemail
changelog
diff --git a/skins/common/oldshared.css b/skins/common/oldshared.css
index b68a996..043c210 100644
--- a/skins/common/oldshared.css
+++ b/skins/common/oldshared.css
@@ -257,10 +257,6 @@
font-style: italic;
}
-span.changedby {
- font-size: 95%;
-}
-
.previewnote {
text-align: center;
color: #cc0000;
diff --git a/skins/common/shared.css b/skins/common/shared.css
index 4c68401..f19f96a 100644
--- a/skins/common/shared.css
+++ b/skins/common/shared.css
@@ -87,13 +87,9 @@
font-style: italic;
}
-/* Comment and username portions of RC entries */
+/* Comment portion of RC entries */
span.comment {
font-style: italic;
-}
-
-span.changedby {
- font-size: 95%;
}
/* Math */
--
To view, visit https://gerrit.wikimedia.org/r/75571
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I795d9c2853d65098b1831467d96b840aaf95a08c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Matmarex <matma....@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
