jenkins-bot has submitted this change and it was merged. Change subject: Show error when trying to save in read-only mode ......................................................................
Show error when trying to save in read-only mode We already correctly show the read only error if the user tries to load VE which the database is locked, but if the database gets locked after they've loaded VE, we also need to show the error when they try to save. Bug: 51636 Change-Id: I7a56f1b4387e7ea594a2a7f939c81626c9eee834 --- M modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js 1 file changed, 7 insertions(+), 0 deletions(-) Approvals: Catrope: Looks good to me, approved jenkins-bot: Verified diff --git a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js b/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js index 860efc7..ff00664 100644 --- a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js +++ b/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js @@ -452,6 +452,13 @@ return; } + if ( data.error ) { + ve.init.mw.Target.onSerializeError.call( + this, null, 'Unsuccessful request: ' + data.error.info, null + ); + return; + } + editApi = data && data.visualeditoredit && data.visualeditoredit.edit; // Handle spam blacklist error (either from core or from Extension:SpamBlacklist) -- To view, visit https://gerrit.wikimedia.org/r/75561 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I7a56f1b4387e7ea594a2a7f939c81626c9eee834 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: master Gerrit-Owner: Esanders <esand...@wikimedia.org> Gerrit-Reviewer: Catrope <roan.katt...@gmail.com> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits