Milimetric has submitted this change and it was merged. Change subject: added heading to metrics page ......................................................................
added heading to metrics page Change-Id: I1cc2e721eadf80f5aaf7cff42099630f3d891dae --- M wikimetrics/templates/metrics.html 1 file changed, 18 insertions(+), 9 deletions(-) Approvals: Milimetric: Verified; Looks good to me, approved diff --git a/wikimetrics/templates/metrics.html b/wikimetrics/templates/metrics.html index 8ed4451..183e276 100644 --- a/wikimetrics/templates/metrics.html +++ b/wikimetrics/templates/metrics.html @@ -14,15 +14,24 @@ <div class="tab-pane{% if loop.first %} active{% endif %}" id="{{m.name}}"> <p class="hero-unit">{{m.description}}</p> <table class="table table-striped"> - {% for f in m.metricClass() %} - {% if f.name != 'csrf_token' %} - <tr> - <td>{{f.label}}</td> - <td>{{f.type}}</td> - <td>{{f.description}}</td> - </tr> - {% endif %} - {% endfor %} + <thead> + <tr> + <th>Parameter</th> + <th>Type</th> + <th>Description</th> + </tr> + </thead> + <tbody> + {% for f in m.metricClass() %} + {% if f.name != 'csrf_token' %} + <tr> + <td>{{f.label}}</td> + <td>{{f.type}}</td> + <td>{{f.description}}</td> + </tr> + {% endif %} + {% endfor %} + </tbody> </table> <pre>{{m.metricClass.__doc__}}</pre> </div> -- To view, visit https://gerrit.wikimedia.org/r/75879 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I1cc2e721eadf80f5aaf7cff42099630f3d891dae Gerrit-PatchSet: 1 Gerrit-Project: analytics/wikimetrics Gerrit-Branch: master Gerrit-Owner: Milimetric <dandree...@wikimedia.org> Gerrit-Reviewer: Milimetric <dandree...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits