[MediaWiki-commits] [Gerrit] Fix: "sitelinks/urls" property in wbgetentities - change (mediawiki...Wikibase)

[Tobias Gritschacher (Code Review)]

Tobias Gritschacher has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/76073


Change subject: Fix: "sitelinks/urls" property in wbgetentities
......................................................................

Fix: "sitelinks/urls" property in wbgetentities

Bug: 52020
Change-Id: If172660e9a3feb638783e75eb3b7ce12191d908f
---
M lib/includes/serializers/SiteLinkSerializer.php
M repo/includes/api/ApiWikibase.php
M repo/includes/api/GetEntities.php
3 files changed, 4 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/73/76073/1

diff --git a/lib/includes/serializers/SiteLinkSerializer.php 
b/lib/includes/serializers/SiteLinkSerializer.php
index 4255cb5..854788e 100644
--- a/lib/includes/serializers/SiteLinkSerializer.php
+++ b/lib/includes/serializers/SiteLinkSerializer.php
@@ -83,7 +83,7 @@
 
                $serialization = array();
 
-               $includeUrls = in_array( 'sitelinks/url', 
$this->options->getProps() );
+               $includeUrls = in_array( 'sitelinks/urls', 
$this->options->getProps() );
 
                foreach ( $this->sortSiteLinks( $siteLinks ) as $link ) {
                        $response = array(
diff --git a/repo/includes/api/ApiWikibase.php 
b/repo/includes/api/ApiWikibase.php
index 4aac85e..646834f 100644
--- a/repo/includes/api/ApiWikibase.php
+++ b/repo/includes/api/ApiWikibase.php
@@ -171,7 +171,7 @@
                        }
 
                        if ( in_array( 'url', $options ) ) {
-                               $serializerOptions->addProp( 'sitelinks/url' );
+                               $serializerOptions->addProp( 'sitelinks/urls' );
                        }
 
                        if ( in_array( 'removed', $options ) ) {
diff --git a/repo/includes/api/GetEntities.php 
b/repo/includes/api/GetEntities.php
index 2b79bf9..debfbfd 100644
--- a/repo/includes/api/GetEntities.php
+++ b/repo/includes/api/GetEntities.php
@@ -165,6 +165,8 @@
                                $options->setLanguages( $params['languages'] );
                                $options->setSortDirection( $params['dir'] );
                                $options->setProps( $props );
+                               #print_r($options->getProps());
+                               #die();
                                $options->setIndexTags( 
$this->getResult()->getIsRawMode() );
 
                                $serializerFactory = new SerializerFactory();

-- 
To view, visit https://gerrit.wikimedia.org/r/76073
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If172660e9a3feb638783e75eb3b7ce12191d908f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Tobias Gritschacher <tobias.gritschac...@wikimedia.de>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits