Aude has submitted this change and it was merged.
Change subject: Removed failing test for illegal time value
......................................................................
Removed failing test for illegal time value
Note that the comment says also something about removing
the validator. I am not sure what is meant with that,
and therefor I left the comment inside, but maybe
this should be done also soon.
Change-Id: Ie69992976344874e79f6c6163cd9e69c835ac3f7
---
M lib/tests/phpunit/WikibaseDataTypeBuildersTest.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Aude: Verified; Looks good to me, approved
diff --git a/lib/tests/phpunit/WikibaseDataTypeBuildersTest.php
b/lib/tests/phpunit/WikibaseDataTypeBuildersTest.php
index de9196c..5851875 100644
--- a/lib/tests/phpunit/WikibaseDataTypeBuildersTest.php
+++ b/lib/tests/phpunit/WikibaseDataTypeBuildersTest.php
@@ -122,7 +122,7 @@
//time['time']
//NOTE: The below will fail with a
IllevalValueExcpetion once the TimeValue constructor enforces the time format.
// Once that is done, this test and the respective
validator can and should both be removed.
- array( 'string', new TimeValue( '2013-06-06 11:22:33',
0, 0, 0, 0, 'http://acme.com/calendar' ), false, 'time: not ISO 8601' ),
+ //array( 'string', new TimeValue( '2013-06-06
11:22:33', 0, 0, 0, 0, 'http://acme.com/calendar' ), false, 'time: not ISO
8601' ),
//TODO: must be an item reference
//TODO: must be from a list of configured values
--
To view, visit https://gerrit.wikimedia.org/r/76094
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie69992976344874e79f6c6163cd9e69c835ac3f7
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: mw1.22-wmf11
Gerrit-Owner: Aude <aude.w...@gmail.com>
Gerrit-Reviewer: Aude <aude.w...@gmail.com>
Gerrit-Reviewer: Denny Vrandecic <denny.vrande...@wikimedia.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
