jenkins-bot has submitted this change and it was merged. Change subject: Improve EditProofreadIndexPage code ......................................................................
Improve EditProofreadIndexPage code Change-Id: I69f36a23af7c93eec527b2b3529411cd2fa73453 --- M includes/index/EditProofreadIndexPage.php 1 file changed, 6 insertions(+), 5 deletions(-) Approvals: Tpt: Looks good to me, approved Zaran: Looks good to me, but someone else must approve jenkins-bot: Verified diff --git a/includes/index/EditProofreadIndexPage.php b/includes/index/EditProofreadIndexPage.php index 43cc8c0..633e783 100644 --- a/includes/index/EditProofreadIndexPage.php +++ b/includes/index/EditProofreadIndexPage.php @@ -33,7 +33,7 @@ $pageLang = $this->mTitle->getPageLanguage(); $inputAttributes = array( 'lang' => $pageLang->getCode(), 'dir' => $pageLang->getDir() ); - if( wfReadOnly() === true ) { + if ( wfReadOnly() ) { $inputAttributes['readonly'] = ''; } @@ -130,9 +130,10 @@ } /** - * Init $this->textbox1 from form content + * Extract the page content data from the posted form * * @param $request WebRequest + * @return string */ protected function importContentFormData( &$request ) { if ( $this->textbox1 !== '' ) { @@ -140,16 +141,16 @@ } $config = ProofreadIndexPage::getDataConfig(); - $this->textbox1 = "{{:MediaWiki:Proofreadpage_index_template"; + $text = "{{:MediaWiki:Proofreadpage_index_template"; foreach( $config as $key => $params ) { $field = $this->getFieldNameForEntry( $key ); $value = $this->cleanInputtedContent( $this->safeUnicodeInput( $request, $field ) ); $entry = new ProofreadIndexEntry( $key, $value, $params ); if( !$entry->isHidden() ) { - $this->textbox1 .= "\n|" . $entry->getKey() . "=" . $entry->getStringValue(); + $text .= "\n|" . $entry->getKey() . "=" . $entry->getStringValue(); } } - $this->textbox1 .= "\n}}"; + return $text . "\n}}"; } /** -- To view, visit https://gerrit.wikimedia.org/r/76344 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I69f36a23af7c93eec527b2b3529411cd2fa73453 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/ProofreadPage Gerrit-Branch: master Gerrit-Owner: Tpt <thoma...@hotmail.fr> Gerrit-Reviewer: Tpt <thoma...@hotmail.fr> Gerrit-Reviewer: Zaran <thibaut.ho...@gmail.com> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits