Tobias Gritschacher has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/76913


Change subject: Fix handling of '0' value in API response
......................................................................

Fix handling of '0' value in API response

Change-Id: I7a284460327ddd2891fcdf45643001c3e1f2f356
---
M repo/includes/api/SetDescription.php
M repo/includes/api/SetLabel.php
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/13/76913/1

diff --git a/repo/includes/api/SetDescription.php 
b/repo/includes/api/SetDescription.php
index 61e1f4d..c5aca4d 100644
--- a/repo/includes/api/SetDescription.php
+++ b/repo/includes/api/SetDescription.php
@@ -48,7 +48,7 @@
                $language = $params['language'];
 
                $this->getChangeOp( $params )->apply( $entity, $summary );
-               $descriptions = array( $language => $entity->getDescription( 
$language ) ? $entity->getDescription( $language ) : "" );
+               $descriptions = array( $language => ( $entity->getDescription( 
$language ) !== false ) ? $entity->getDescription( $language ) : "" );
                $this->addDescriptionsToResult( $descriptions, 'entity' );
 
                wfProfileOut( __METHOD__ );
diff --git a/repo/includes/api/SetLabel.php b/repo/includes/api/SetLabel.php
index b2a00a6..a434a42 100644
--- a/repo/includes/api/SetLabel.php
+++ b/repo/includes/api/SetLabel.php
@@ -47,7 +47,7 @@
                $language = $params['language'];
 
                $this->getChangeOp( $params )->apply( $entity, $summary );
-               $labels = array( $language => $entity->getLabel( $language ) ? 
$entity->getLabel( $language ) : "" );
+               $labels = array( $language => ( $entity->getLabel( $language ) 
!== false ) ? $entity->getLabel( $language ) : "" );
                $this->addLabelsToResult( $labels, 'entity' );
 
                wfProfileOut( __METHOD__ );

-- 
To view, visit https://gerrit.wikimedia.org/r/76913
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7a284460327ddd2891fcdf45643001c3e1f2f356
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Tobias Gritschacher <tobias.gritschac...@wikimedia.de>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to