Andrew Bogott has submitted this change and it was merged.

Change subject: define ishmael_config() parameters lacked dollar signs
......................................................................


define ishmael_config() parameters lacked dollar signs

`puppet parser validate` is giving me errors on ishmael_config since
its parameter names are lacking dollars.

I.e:

 Error: Could not parse for environment production:
 Syntax error at 'db_central_host'; expected ')'
 at manifests/misc/ishmael.pp:22

Change-Id: If563ec2f7bd6383b8c52cb3d3541458bed6f5f8b
---
M manifests/misc/ishmael.pp
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Andrew Bogott: Looks good to me, approved
  Akosiaris: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/manifests/misc/ishmael.pp b/manifests/misc/ishmael.pp
index bf473c2..7be4a8f 100644
--- a/manifests/misc/ishmael.pp
+++ b/manifests/misc/ishmael.pp
@@ -19,7 +19,7 @@
 
        apache_site { 'ishmael': name => 'ishmael.wikimedia.org' }
 
-       define ishmael_config( db_central_host='db1001.eqiad.wmnet', 
review_table='%query_review', history_table='%query_review_history' ) {
+       define ishmael_config( $db_central_host='db1001.eqiad.wmnet', 
$review_table='%query_review', $history_table='%query_review_history' ) {
                include passwords::mysql::querydigest
 
                file { $title:

-- 
To view, visit https://gerrit.wikimedia.org/r/76280
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If563ec2f7bd6383b8c52cb3d3541458bed6f5f8b
Gerrit-PatchSet: 3
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Hashar <has...@free.fr>
Gerrit-Reviewer: Akosiaris <akosia...@wikimedia.org>
Gerrit-Reviewer: Andrew Bogott <abog...@wikimedia.org>
Gerrit-Reviewer: Asher <afeld...@wikimedia.org>
Gerrit-Reviewer: Hashar <has...@free.fr>
Gerrit-Reviewer: Pyoungmeister <p...@wikimedia.org>
Gerrit-Reviewer: Springle <sprin...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to