Milimetric has submitted this change and it was merged. Change subject: fixed decimal adding issue on aggregates ......................................................................
fixed decimal adding issue on aggregates Change-Id: Ie2c287705542250103451d3945a2980691274adc --- M wikimetrics/models/report_nodes/aggregate_report.py 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: Milimetric: Verified; Looks good to me, approved diff --git a/wikimetrics/models/report_nodes/aggregate_report.py b/wikimetrics/models/report_nodes/aggregate_report.py index 09a08f1..990252a 100644 --- a/wikimetrics/models/report_nodes/aggregate_report.py +++ b/wikimetrics/models/report_nodes/aggregate_report.py @@ -1,3 +1,4 @@ +from decimal import Decimal from wikimetrics.utils import stringify from report import ReportNode from multi_project_metric_report import MultiProjectMetricReport @@ -96,14 +97,14 @@ if not key in aggregation: aggregation[key] = 0 helper[key] = dict() - helper[key]['sum'] = 0.0 + helper[key]['sum'] = Decimal(0.0) helper[key]['count'] = 0 value = results_by_user[user_id][key] if not value: - value = 0 + value = Decimal(0) - helper[key]['sum'] += value + helper[key]['sum'] += Decimal(value) helper[key]['count'] += 1 if type_of_aggregate == Aggregation.SUM: -- To view, visit https://gerrit.wikimedia.org/r/76932 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ie2c287705542250103451d3945a2980691274adc Gerrit-PatchSet: 1 Gerrit-Project: analytics/wikimetrics Gerrit-Branch: master Gerrit-Owner: Milimetric <dandree...@wikimedia.org> Gerrit-Reviewer: Milimetric <dandree...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits