Ori.livneh has uploaded a new change for review. https://gerrit.wikimedia.org/r/77259
Change subject: Fix broken 'unless' condition for Exec['set mysql password'] ...................................................................... Fix broken 'unless' condition for Exec['set mysql password'] mysqladmin's "ping" subcommand returns 0 for both success and failure, so it is unsuitable as a predicate. "status" had the right behavior. Change-Id: I0f69e59b92f86dd3579b603a550aa4f91e5643fd --- M puppet/modules/mysql/manifests/init.pp 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/vagrant refs/changes/59/77259/1 diff --git a/puppet/modules/mysql/manifests/init.pp b/puppet/modules/mysql/manifests/init.pp index 8199163..75263d1 100644 --- a/puppet/modules/mysql/manifests/init.pp +++ b/puppet/modules/mysql/manifests/init.pp @@ -36,7 +36,7 @@ exec { 'set mysql password': command => "mysqladmin -u root password \"${root_password}\"", - unless => "mysqladmin -u root -p\"${root_password}\" ping", + unless => "mysqladmin -u root -p\"${root_password}\" status", require => Service['mysql'], } -- To view, visit https://gerrit.wikimedia.org/r/77259 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0f69e59b92f86dd3579b603a550aa4f91e5643fd Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/vagrant Gerrit-Branch: master Gerrit-Owner: Ori.livneh <o...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits