Rfaulk has submitted this change and it was merged.
Change subject: fix. Initialize parsed request args unconditionally.
......................................................................
fix. Initialize parsed request args unconditionally.
Change-Id: I14c8211100044ba4104a92f813b016da388f1a30
---
M user_metrics/api/engine/request_meta.py
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Rfaulk: Verified; Looks good to me, approved
diff --git a/user_metrics/api/engine/request_meta.py
b/user_metrics/api/engine/request_meta.py
index 8b28761..1bfeef2 100644
--- a/user_metrics/api/engine/request_meta.py
+++ b/user_metrics/api/engine/request_meta.py
@@ -71,10 +71,9 @@
bits = bits[1].split('?')
metric = bits[0]
- args = namedtuple('UM_REQUEST_ARGS', '')
+ args = dict()
if len(bits) > 1:
args_expr = [i.split('=') for i in bits[1].split('&')]
- args = dict()
for arg in args_expr:
if len(arg) == 1:
# The arg is simply present
--
To view, visit https://gerrit.wikimedia.org/r/78211
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I14c8211100044ba4104a92f813b016da388f1a30
Gerrit-PatchSet: 1
Gerrit-Project: analytics/user-metrics
Gerrit-Branch: master
Gerrit-Owner: Rfaulk <rfaulk...@wikimedia.org>
Gerrit-Reviewer: Rfaulk <rfaulk...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
