Ryan Lane has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/78213


Change subject: htmlform muliselect chosen: convert each list
......................................................................

htmlform muliselect chosen: convert each list

This change converts each checkbox list input separately, rather
than converting all together into a single select input.

Change-Id: Iec6687f7105cdb38fb92785aaa4357babaef1b4f
---
M resources/mediawiki/mediawiki.htmlform.js
1 file changed, 4 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/13/78213/1

diff --git a/resources/mediawiki/mediawiki.htmlform.js 
b/resources/mediawiki/mediawiki.htmlform.js
index 77ceee4..aedb28d 100644
--- a/resources/mediawiki/mediawiki.htmlform.js
+++ b/resources/mediawiki/mediawiki.htmlform.js
@@ -112,16 +112,14 @@
                mw.loader.using( 'jquery.chosen', function () {
                        var $toConvert,
                        $converted;
-                       $toConvert = $( 'table .mw-chosen' );
-                       if ( $toConvert.length ) {
+                       $( 'table .mw-chosen' ).each( function () {
                                $converted = convertCheckboxesToMulti( 
$toConvert, 'table' );
                                $converted.find( '.htmlform-chzn-select' 
).chosen( { width: 'auto' } );
-                       }
-                       $toConvert = $( 'div .mw-chosen' );
-                       if ( $toConvert.length ) {
+                       } );
+                       $( 'div .mw-chosen' ).each( function () {
                                $converted = convertCheckboxesToMulti( 
$toConvert, 'div' );
                                $converted.find( '.htmlform-chzn-select' 
).chosen( { width: 'auto' } );
-                       }
+                       } );
                } );
        }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/78213
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iec6687f7105cdb38fb92785aaa4357babaef1b4f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Ryan Lane <rl...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to