Tobias Gritschacher has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/78221


Change subject: (bug 52635) broken autocomments for "0" values
......................................................................

(bug 52635) broken autocomments for "0" values

Change-Id: Icd77c08e697a2be0708ecf0c92cb2a930cb430b5
---
M repo/Wikibase.hooks.php
1 file changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase 
refs/changes/21/78221/1

diff --git a/repo/Wikibase.hooks.php b/repo/Wikibase.hooks.php
index bfc0cd8..91350e7 100644
--- a/repo/Wikibase.hooks.php
+++ b/repo/Wikibase.hooks.php
@@ -1003,11 +1003,11 @@
                                $auto = $msg->params( $args )->parse();
 
                                // add pre and post fragments
-                               if ( $pre ) {
+                               if ( $pre !== '' ) {
                                        // written summary $presep autocomment 
(summary /* section */)
                                        $pre .= wfMessage( 'autocomment-prefix' 
)->escaped();
                                }
-                               if ( $post ) {
+                               if ( $post !== '' ) {
                                        // autocomment $postsep written summary 
(/* section */ summary)
                                        $auto .= wfMessage( 'colon-separator' 
)->escaped();
                                }

-- 
To view, visit https://gerrit.wikimedia.org/r/78221
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icd77c08e697a2be0708ecf0c92cb2a930cb430b5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Tobias Gritschacher <tobias.gritschac...@wikimedia.de>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to