[MediaWiki-commits] [Gerrit] Add subscript tool - change (mediawiki...VisualEditor)

[Steven Zhang (Code Review)]

Steven Zhang has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/78495


Change subject: Add subscript tool
......................................................................

Add subscript tool

Bug: 51612
Change-Id: Ia05e09a411213cbc035ad9dd3d3156d57f8e102c
---
M VisualEditor.i18n.php
M VisualEditor.php
M modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
M modules/ve/init/ve.init.Target.js
A modules/ve/ui/tools/buttons/ve.ui.SubScriptButtonTool.js
5 files changed, 47 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/95/78495/1

diff --git a/VisualEditor.i18n.php b/VisualEditor.i18n.php
index 4832183..3d2c53f 100644
--- a/VisualEditor.i18n.php
+++ b/VisualEditor.i18n.php
@@ -258,6 +258,8 @@
 {{Identical|Underline}}',
        'visualeditor-annotationbutton-superscript-tooltip' => 'Tooltip text 
for superscript button.
 {{Identical|Superscript}}',
+       'visualeditor-annotationbutton-subscript-tooltip' => 'Tooltip text for 
subscript button.
+{{Identical|Subscript}}',
 
        'visualeditor-beta-label' => 'Text of tool in the toolbar that 
highlights that VisualEditor is still in beta.
 {{Identical|Beta}}',
diff --git a/VisualEditor.php b/VisualEditor.php
index ad947c1..2dcb7d4 100644
--- a/VisualEditor.php
+++ b/VisualEditor.php
@@ -734,6 +734,7 @@
                        've/ui/tools/buttons/ve.ui.StrikethroughButtonTool.js',
                        've/ui/tools/buttons/ve.ui.UnderlineButtonTool.js',
                        've/ui/tools/buttons/ve.ui.SuperScriptButtonTool.js',
+                       've/ui/tools/buttons/ve.ui.SubScriptButtonTool.js',
                ),
                'dependencies' => array(
                        'ext.visualEditor.core',
@@ -748,6 +749,7 @@
                        'visualeditor-annotationbutton-strikethrough-tooltip',
                        'visualeditor-annotationbutton-underline-tooltip',
                        'visualeditor-annotationbuttin-superscript-tooltip',
+                       'visualeditor-annotationbuttin-subscript-tooltip',
                ),
        ),
 
diff --git a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js 
b/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
index 860d45f..729f936 100644
--- a/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
+++ b/modules/ve-mw/init/targets/ve.init.mw.ViewPageTarget.js
@@ -170,7 +170,7 @@
 ve.init.mw.ViewPageTarget.static.toolbarTools = [
        { 'items': [ 'undo', 'redo' ] },
        { 'items': [ 'mwFormat' ] },
-       { 'items': [ 'bold', 'italic', 'mwLink', 'language', 'code', 
'underline', 'strikethrough', 'superscript', 'clear' ] },
+       { 'items': [ 'bold', 'italic', 'mwLink', 'language', 'code', 
'underline', 'strikethrough', 'superscript', 'subscript', 'clear' ] },
        { 'items': [ 'number', 'bullet', 'outdent', 'indent' ] },
        { 'items': [ 'mwMediaInsert', 'mwReference', 'mwReferenceList', 
'mwTransclusion', 'mwMath', 'mwHiero' ] }
 ];
diff --git a/modules/ve/init/ve.init.Target.js 
b/modules/ve/init/ve.init.Target.js
index 7ba4e19..feddcc9 100644
--- a/modules/ve/init/ve.init.Target.js
+++ b/modules/ve/init/ve.init.Target.js
@@ -32,7 +32,7 @@
 ve.init.Target.static.toolbarTools = [
        { 'items': ['undo', 'redo'] },
        { 'items': ['format'] },
-       { 'items': ['bold', 'italic', 'link', 'code', 'language', 'underline', 
'strikethrough', 'superscript', 'clear'] },
+       { 'items': ['bold', 'italic', 'link', 'code', 'language', 'underline', 
'strikethrough', 'superscript', 'subscript', 'clear'] },
        { 'items': ['number', 'bullet', 'outdent', 'indent'] }
 ];
 
@@ -46,6 +46,7 @@
        //'underline', 
        //'strikethrough',
        //'superscript',
+       //'subscript',
        'indent',
        'outdent'
 ];
diff --git a/modules/ve/ui/tools/buttons/ve.ui.SubScriptButtonTool.js 
b/modules/ve/ui/tools/buttons/ve.ui.SubScriptButtonTool.js
new file mode 100644
index 0000000..e9d262b
--- /dev/null
+++ b/modules/ve/ui/tools/buttons/ve.ui.SubScriptButtonTool.js
@@ -0,0 +1,40 @@
+/*!
+ * VisualEditor UserInterface SubScriptButtonTool class.
+ *
+ * @copyright 2011-2013 VisualEditor Team and others; see AUTHORS.txt
+ * @license The MIT License (MIT); see LICENSE.txt
+ */
+
+/**
+ * UserInterface code button tool.
+ *
+ * @class
+ * @extends ve.ui.AnnotationButtonTool
+ * @constructor
+ * @param {ve.ui.SurfaceToolbar} toolbar
+ * @param {Object} [config] Config options
+ */
+ve.ui.SubScriptButtonTool = function VeUiSubScriptuttonTool( toolbar, config ) 
{
+       // Parent constructor
+       ve.ui.AnnotationButtonTool.call( this, toolbar, config );
+};
+
+/* Inheritance */
+
+ve.inheritClass( ve.ui.SubScriptButtonTool, ve.ui.AnnotationButtonTool );
+
+/* Static Properties */
+
+ve.ui.SubScriptButtonTool.static.name = 'subscript';
+
+ve.ui.SubScriptButtonTool.static.icon = 'subscript';
+
+ve.ui.SubScriptButtonTool.static.titleMessage = 
'visualeditor-annotationbutton-subscript-tooltip';
+
+ve.ui.SubScriptButtonTool.static.annotation = { 'name': 'textStyle/subScript' 
};
+
+/* Registration */
+
+ve.ui.toolFactory.register( 'subscript', ve.ui.SubScriptButtonTool );
+
+ve.ui.commandRegistry.register( 'subscript', 'annotation', 'toggle', 
'textStyle/subScript' );

-- 
To view, visit https://gerrit.wikimedia.org/r/78495
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia05e09a411213cbc035ad9dd3d3156d57f8e102c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Steven Zhang <cro0...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits