Esanders has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/79188


Change subject: Fix logical conflict from I8feefd9e8
......................................................................

Fix logical conflict from I8feefd9e8

onUpdate was renamed to update. Also neither event was
actually implemented so have just removed them.

Change-Id: Iaae1661a99f97272fa42c71223fc2cb832d50c66
---
M modules/ve-mw/ce/nodes/ve.ce.MWExtensionNode.js
1 file changed, 0 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor 
refs/changes/88/79188/1

diff --git a/modules/ve-mw/ce/nodes/ve.ce.MWExtensionNode.js 
b/modules/ve-mw/ce/nodes/ve.ce.MWExtensionNode.js
index b0d17fa..916c6d0 100644
--- a/modules/ve-mw/ce/nodes/ve.ce.MWExtensionNode.js
+++ b/modules/ve-mw/ce/nodes/ve.ce.MWExtensionNode.js
@@ -30,10 +30,6 @@
        ve.ce.ProtectedNode.call( this );
        ve.ce.GeneratedContentNode.call( this );
 
-       // Events
-       this.model.connect( this, { 'update': 'onUpdate' } );
-       this.$.on( 'click', ve.bind( this.onClick, this ) );
-
        // DOM Changes
        this.$.addClass( 've-ce-mwExtensionNode' );
 };

-- 
To view, visit https://gerrit.wikimedia.org/r/79188
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iaae1661a99f97272fa42c71223fc2cb832d50c66
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <esand...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to