CSteipp has submitted this change and it was merged.
Change subject: Fixed wrong comments
......................................................................
Fixed wrong comments
Change-Id: Ic64633ada890526e3251061669b4be35eac3211b
---
M backend/MWOAuthUtils.php
1 file changed, 1 insertion(+), 3 deletions(-)
Approvals:
CSteipp: Verified; Looks good to me, approved
diff --git a/backend/MWOAuthUtils.php b/backend/MWOAuthUtils.php
index 759e713..0af3a17 100644
--- a/backend/MWOAuthUtils.php
+++ b/backend/MWOAuthUtils.php
@@ -234,7 +234,7 @@
}
/**
- * Given a central wiki user ID, get a local User object
+ * Given a central wiki user ID, get a central user name
*
* @param integer $userId
* @return string|bool User name or false if not found
@@ -244,8 +244,6 @@
if ( $wgMWOAuthSharedUserIDs ) { // global ID required via hook
$namesById = array( $userId => false );
- // Let extensions check that central wiki user ID is
attached to a global account
- // and that return the user on this wiki that is
attached to that global account
wfRunHooks( 'OAuthGetUserNamesFromCentralIds',
array( $wgMWOAuthCentralWiki, &$namesById ) );
$name = $namesById[$userId];
--
To view, visit https://gerrit.wikimedia.org/r/79213
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic64633ada890526e3251061669b4be35eac3211b
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/OAuth
Gerrit-Branch: master
Gerrit-Owner: Aaron Schulz <asch...@wikimedia.org>
Gerrit-Reviewer: CSteipp <cste...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
