TheDJ has submitted this change and it was merged. Change subject: EditPage: Wrap the pipe between "Cancel" and "Editing help" links in a <span> ......................................................................
EditPage: Wrap the pipe between "Cancel" and "Editing help" links in a <span> This will make it possible to hide or style it without nasty hacks like the one Vector extension's ext.vector.footerCleanup module uses. Bug: 43689 Change-Id: Id9269876939d3453c53473f7e3650c375f6fdd22 --- M includes/EditPage.php 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: TheDJ: Looks good to me, approved jenkins-bot: Verified diff --git a/includes/EditPage.php b/includes/EditPage.php index 22cf795..f8788b7 100644 --- a/includes/EditPage.php +++ b/includes/EditPage.php @@ -2881,7 +2881,9 @@ $cancel = $this->getCancelLink(); if ( $cancel !== '' ) { - $cancel .= wfMessage( 'pipe-separator' )->text(); + $cancel .= Html::element( 'span', + array( 'class' => 'mw-editButtons-pipe-separator' ), + wfMessage( 'pipe-separator' )->text() ); } $edithelpurl = Skin::makeInternalOrExternalUrl( wfMessage( 'edithelppage' )->inContentLanguage()->text() ); $edithelp = '<a target="helpwindow" href="' . $edithelpurl . '">' . -- To view, visit https://gerrit.wikimedia.org/r/76068 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Id9269876939d3453c53473f7e3650c375f6fdd22 Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Matmarex <matma....@gmail.com> Gerrit-Reviewer: Catrope <roan.katt...@gmail.com> Gerrit-Reviewer: MZMcBride <w...@mzmcbride.com> Gerrit-Reviewer: Matmarex <matma....@gmail.com> Gerrit-Reviewer: TheDJ <hartman.w...@gmail.com> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits