Faidon has submitted this change and it was merged.
Change subject: sysctlfile: add newline for value invocations
......................................................................
sysctlfile: add newline for value invocations
/etc/init/procps does "cat /etc/sysctl.d/*.conf /etc/sysctl.conf | sysctl
-e -p", so not having a newline means at best means settings being
ignored, at worst means having random keys being set as values of other
keys...
Change-Id: I8dcc5779b06c188f8cc6c16c3011f252c1736180
---
M modules/sysctlfile/manifests/init.pp
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Faidon: Verified; Looks good to me, approved
diff --git a/modules/sysctlfile/manifests/init.pp
b/modules/sysctlfile/manifests/init.pp
index 189b4e7..3b23cbf 100644
--- a/modules/sysctlfile/manifests/init.pp
+++ b/modules/sysctlfile/manifests/init.pp
@@ -42,7 +42,7 @@
# if using $value, then set $key = $value in the sysctl.d file
if $value {
- File[$sysctl_file] { content => "${key} = ${value}" }
+ File[$sysctl_file] { content => "${key} = ${value}\n" }
}
# else just set the content
elsif $content {
--
To view, visit https://gerrit.wikimedia.org/r/79323
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I8dcc5779b06c188f8cc6c16c3011f252c1736180
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Faidon <fai...@wikimedia.org>
Gerrit-Reviewer: Faidon <fai...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
