jenkins-bot has submitted this change and it was merged.
Change subject: Fix big writes in tests.
......................................................................
Fix big writes in tests.
When we sent a whole article to the page using selenium this caused
firefox to lock up. Now, instead of sending the whole article we chunk
it and send it. No more locking up!
Change-Id: I99bd1d0c115d4eb8c30f9a89dece45c1b55066e8
---
M tests/browser/features/step_definitions/page_steps.rb
1 file changed, 8 insertions(+), 4 deletions(-)
Approvals:
Demon: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/browser/features/step_definitions/page_steps.rb
b/tests/browser/features/step_definitions/page_steps.rb
index 972bb72..0a58ab4 100644
--- a/tests/browser/features/step_definitions/page_steps.rb
+++ b/tests/browser/features/step_definitions/page_steps.rb
@@ -30,10 +30,14 @@
step 'I am logged in'
visit(EditPage, using_params: {page_name: title})
end
- if (add) then
- page.article_text += text
- else
- page.article_text = text
+ if !add then
+ page.article_text = ''
+ end
+ # Firefox chokes on huge batches of text so split it into chunks and use
+ # send_keys rather than page-objects built in += because that clears and
+ # resends everything....
+ text.chars.each_slice(1000) do |chunk|
+ page.article_text_element.send_keys(chunk)
end
page.save
end
--
To view, visit https://gerrit.wikimedia.org/r/79227
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I99bd1d0c115d4eb8c30f9a89dece45c1b55066e8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CirrusSearch
Gerrit-Branch: master
Gerrit-Owner: Manybubbles <never...@wikimedia.org>
Gerrit-Reviewer: Cmcmahon <cmcma...@wikimedia.org>
Gerrit-Reviewer: Demon <ch...@wikimedia.org>
Gerrit-Reviewer: Zfilipin <zfili...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
