jenkins-bot has submitted this change and it was merged. Change subject: Fixing "Common language" functionality ......................................................................
Fixing "Common language" functionality If was broken in Icda498f676d1d3ddaefad75fd9212150f6966666 Bug: 53035 Change-Id: Ida29364073b07b985050565cacc6634c134f8d6c --- M resources/js/ext.uls.interface.js 1 file changed, 6 insertions(+), 7 deletions(-) Approvals: Nikerabbit: Looks good to me, approved jenkins-bot: Verified diff --git a/resources/js/ext.uls.interface.js b/resources/js/ext.uls.interface.js index c5553b6..128ac66 100644 --- a/resources/js/ext.uls.interface.js +++ b/resources/js/ext.uls.interface.js @@ -400,16 +400,17 @@ } ); } else { $ulsTrigger.on( 'click', function ( e, eventParams ) { - var uls = $ulsTrigger.data( 'uls' ), - ulsOptions; + var uls = $ulsTrigger.data( 'uls' ); if ( uls ) { if ( !uls.shown ) { mw.hook( 'mw.uls.settings.open' ).fire( eventParams && eventParams.source || 'personal' ); } } else { - // ULS options that are common to all modes of showing - ulsOptions = { + $ulsTrigger.uls( { + quickList: function () { + return mw.uls.getFrequentLanguageList(); + }, onReady: function () { var uls = this; mw.loader.using( mw.uls.languageSettingsModules, function () { @@ -420,9 +421,7 @@ onSelect: function ( language ) { mw.uls.changeLanguage( language ); } - }; - - $ulsTrigger.uls( ulsOptions ).trigger( 'click', eventParams ); + } ).trigger( 'click', eventParams ); e.stopPropagation(); } -- To view, visit https://gerrit.wikimedia.org/r/79781 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ida29364073b07b985050565cacc6634c134f8d6c Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/UniversalLanguageSelector Gerrit-Branch: master Gerrit-Owner: Amire80 <amir.ahar...@mail.huji.ac.il> Gerrit-Reviewer: Nikerabbit <niklas.laxst...@gmail.com> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits