Faidon has submitted this change and it was merged.

Change subject: git::clone: fix clones with unprivileged users
......................................................................


git::clone: fix clones with unprivileged users

Set current directory of git::clone's exec to /tmp to get rid of fatals:
fatal: Could not change back to '/root': Permission denied

Change-Id: I52711d3c24a40ff4f5e655e0a7c86130da69ae3b
---
M manifests/generic-definitions.pp
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  Faidon: Verified; Looks good to me, approved
  jenkins-bot: Verified



diff --git a/manifests/generic-definitions.pp b/manifests/generic-definitions.pp
index 252fd89..8973d58 100644
--- a/manifests/generic-definitions.pp
+++ b/manifests/generic-definitions.pp
@@ -304,6 +304,7 @@
                        exec { "git_clone_${title}":
                                command     => "git clone 
${brancharg}${origin}${deptharg} $directory",
                                logoutput   => on_failure,
+                               cwd         => '/tmp',
                                environment => $env,
                                creates     => "$directory/.git/config",
                                user        => $owner,

-- 
To view, visit https://gerrit.wikimedia.org/r/79827
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I52711d3c24a40ff4f5e655e0a7c86130da69ae3b
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Faidon <fai...@wikimedia.org>
Gerrit-Reviewer: Faidon <fai...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to