[MediaWiki-commits] [Gerrit] Add compatibility test for GlobeCoordinateValue serialization - change (mediawiki...DataValues)

[Jeroen De Dauw (Code Review)]

Jeroen De Dauw has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/80197


Change subject: Add compatibility test for GlobeCoordinateValue serialization
......................................................................

Add compatibility test for GlobeCoordinateValue serialization

Change-Id: Ic33bf4b3326dcac30b18b9be36cda6a2274e6c6a
---
M DataValues/tests/phpunit/GlobeCoordinateValueTest.php
1 file changed, 24 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/DataValues 
refs/changes/97/80197/1

diff --git a/DataValues/tests/phpunit/GlobeCoordinateValueTest.php 
b/DataValues/tests/phpunit/GlobeCoordinateValueTest.php
index c86c9df..be83e25 100644
--- a/DataValues/tests/phpunit/GlobeCoordinateValueTest.php
+++ b/DataValues/tests/phpunit/GlobeCoordinateValueTest.php
@@ -126,4 +126,28 @@
                $this->assertEquals( $expected, $actual );
        }
 
+       public function testArrayValueCompatibility() {
+               $simpleSerialization = 
'a:5:{s:8:"latitude";d:-4.2000000000000002;s:9:"longitude";d:42;s:8:"altitude";N;s:9:"precision";d:0.01;s:5:"globe";s:4:"mars";}';
+
+               $arrayForm = unserialize( $simpleSerialization );
+               $geoCoordinate = GlobeCoordinateValue::newFromArray( $arrayForm 
);
+
+               $this->assertEquals( -4.2, $geoCoordinate->getLatitude() );
+               $this->assertEquals( 42, $geoCoordinate->getLongitude() );
+               $this->assertEquals( 0.01, $geoCoordinate->getPrecision() );
+               $this->assertEquals( 'mars', $geoCoordinate->getGlobe() );
+
+               $simpleSerialization = 
'a:5:{s:8:"latitude";d:-4.2000000000000002;s:9:"longitude";d:-42;s:8:"altitude";d:9001;s:9:"precision";d:1;s:5:"globe";s:33:"http://www.wikidata.org/entity/Q2";}';
+
+               $arrayForm = unserialize( $simpleSerialization );
+               $geoCoordinate = GlobeCoordinateValue::newFromArray( $arrayForm 
);
+
+               $this->assertEquals( -4.2, $geoCoordinate->getLatitude() );
+               $this->assertEquals( -42, $geoCoordinate->getLongitude() );
+               $this->assertEquals( 1, $geoCoordinate->getPrecision() );
+               $this->assertEquals( 'http://www.wikidata.org/entity/Q2', 
$geoCoordinate->getGlobe() );
+       }
+
+       // TODO: add compatibility test for using serialize directly
+
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/80197
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic33bf4b3326dcac30b18b9be36cda6a2274e6c6a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/DataValues
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <jeroended...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits