[MediaWiki-commits] [Gerrit] Implement Serializer and Deserializer interfaces - change (mediawiki...WikibaseQuery)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: Implement Serializer and Deserializer interfaces
......................................................................


Implement Serializer and Deserializer interfaces

Change-Id: Ie2bbbee182c69da3d3e95fe139482db19da4b811
---
M Tests/Phpunit/Wikibase/Query/QueryEntitySerializerTest.php
M src/Wikibase/Query/QueryEntityDeserializer.php
M src/Wikibase/Query/QueryEntitySerializer.php
3 files changed, 22 insertions(+), 2 deletions(-)

Approvals:
  Addshore: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/Tests/Phpunit/Wikibase/Query/QueryEntitySerializerTest.php 
b/Tests/Phpunit/Wikibase/Query/QueryEntitySerializerTest.php
index 7b6dd42..50af9ad 100644
--- a/Tests/Phpunit/Wikibase/Query/QueryEntitySerializerTest.php
+++ b/Tests/Phpunit/Wikibase/Query/QueryEntitySerializerTest.php
@@ -70,6 +70,21 @@
                return $argLists;
        }
 
+       /**
+        * @dataProvider notAQueryEntityProvider
+        */
+       public function testCannotSerialize( $notAQueryEntity ) {
+               $serializer = $this->newSimpleQueryEntitySerializer();
+
+               $this->assertFalse( $serializer->canSerialize( $notAQueryEntity 
) );
+       }
+
+       public function testCanSerialize() {
+               $queryEntity = $this->newSimpleEntity();
+               $serializer = $this->newSimpleQueryEntitySerializer();
+               $this->assertTrue( $serializer->canSerialize( $queryEntity ) );
+       }
+
        public function testSerializationCallsQuerySerialization() {
                $querySerializer = $this->getMock( 'Serializers\Serializer' );
 
diff --git a/src/Wikibase/Query/QueryEntityDeserializer.php 
b/src/Wikibase/Query/QueryEntityDeserializer.php
index c799187..1a05fcc 100644
--- a/src/Wikibase/Query/QueryEntityDeserializer.php
+++ b/src/Wikibase/Query/QueryEntityDeserializer.php
@@ -17,7 +17,7 @@
  * @author Jeroen De Dauw < jeroended...@gmail.com >
  * @author Adam Shorland < adamshorl...@gmail.com >
  */
-class QueryEntityDeserializer {
+class QueryEntityDeserializer implements Deserializer {
 
        protected $queryDeserializer;
 
diff --git a/src/Wikibase/Query/QueryEntitySerializer.php 
b/src/Wikibase/Query/QueryEntitySerializer.php
index 919dab0..fd57838 100644
--- a/src/Wikibase/Query/QueryEntitySerializer.php
+++ b/src/Wikibase/Query/QueryEntitySerializer.php
@@ -16,7 +16,7 @@
  * @author Jeroen De Dauw < jeroended...@gmail.com >
  * @author Adam Shorland < adamshorl...@gmail.com >
  */
-class QueryEntitySerializer {
+class QueryEntitySerializer implements Serializer {
 
        protected $querySerializer;
 
@@ -66,4 +66,9 @@
                return $serializedClaims;
        }
 
+
+       public function canSerialize( $mixed ) {
+               return $mixed instanceof QueryEntity;
+       }
+
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/80015
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ie2bbbee182c69da3d3e95fe139482db19da4b811
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/WikibaseQuery
Gerrit-Branch: master
Gerrit-Owner: Jeroen De Dauw <jeroended...@gmail.com>
Gerrit-Reviewer: Addshore <addshorew...@gmail.com>
Gerrit-Reviewer: Aude <aude.w...@gmail.com>
Gerrit-Reviewer: Tobias Gritschacher <tobias.gritschac...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits