[MediaWiki-commits] [Gerrit] Put 'use strict' at top of outermost function in all files - change (mediawiki...GettingStarted)

[Mattflaschen (Code Review)]

Mattflaschen has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/80342


Change subject: Put 'use strict' at top of outermost function in all files
......................................................................

Put 'use strict' at top of outermost function in all files

Change-Id: Ib35a5085e7550d57520c383ffe2fe711b0fb470e
---
M resources/ext.gettingstarted.common.accountCreation.js
M resources/ext.gettingstarted.js
M resources/ext.gettingstarted.openTask.js
M resources/ext.gettingstarted.specialPage.js
M resources/ext.gettingstarted.taskToolbar.js
M resources/tours/gettingstartedtasktoolbar.js
M resources/tours/gettingstartedtasktoolbarintro.js
M resources/tours/gettingstartedtasktoolbarve.js
8 files changed, 16 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/GettingStarted 
refs/changes/42/80342/1

diff --git a/resources/ext.gettingstarted.common.accountCreation.js 
b/resources/ext.gettingstarted.common.accountCreation.js
index 3c8a64c..48b1287 100644
--- a/resources/ext.gettingstarted.common.accountCreation.js
+++ b/resources/ext.gettingstarted.common.accountCreation.js
@@ -1,4 +1,6 @@
 ( function ( mw, $ ) {
+       'use strict';
+
        var logging = mw.gettingStarted.logging;
 
        /**
diff --git a/resources/ext.gettingstarted.js b/resources/ext.gettingstarted.js
index f3eff2b..57072cc 100644
--- a/resources/ext.gettingstarted.js
+++ b/resources/ext.gettingstarted.js
@@ -2,6 +2,8 @@
 // special page, or the post-account creation version.
 
 ( function ( $, mw ) {
+       'use strict';
+
        $( function () {
                var isWelcomeCreation = mw.config.get( 'wgIsWelcomeCreation' ),
                        isNew = !!isWelcomeCreation,
diff --git a/resources/ext.gettingstarted.openTask.js 
b/resources/ext.gettingstarted.openTask.js
index 389181a..8656732 100644
--- a/resources/ext.gettingstarted.openTask.js
+++ b/resources/ext.gettingstarted.openTask.js
@@ -1,6 +1,8 @@
 // This file is based on openTask from the E3Experiments extension, so consult 
that repo for earlier history.
 
 ( function ( $, mw ) {
+       'use strict';
+
        // Runs on every page, checks to see if this page is in the user's task 
list,
        // and if so logs certain user actions.
        var task, schemaAction, logging = mw.gettingStarted.logging;
diff --git a/resources/ext.gettingstarted.specialPage.js 
b/resources/ext.gettingstarted.specialPage.js
index e27b6fa..f21aa30 100644
--- a/resources/ext.gettingstarted.specialPage.js
+++ b/resources/ext.gettingstarted.specialPage.js
@@ -1,4 +1,6 @@
 ( function ( mw ) {
+       'use strict';
+
        var event = {
                action: 'gettingstarted-specialpage-impression',
                isNew: false
diff --git a/resources/ext.gettingstarted.taskToolbar.js 
b/resources/ext.gettingstarted.taskToolbar.js
index d397031..ff07cf5 100644
--- a/resources/ext.gettingstarted.taskToolbar.js
+++ b/resources/ext.gettingstarted.taskToolbar.js
@@ -1,4 +1,6 @@
 ( function ( $, mw ) {
+       'use strict';
+
        $( document ).ready( function () {
                var $toolbar, $left, $center, $centerMessage, $right, 
$tryAnother, $close,
                toolbarInfo, $relativeElements, $marginElements, logging,
diff --git a/resources/tours/gettingstartedtasktoolbar.js 
b/resources/tours/gettingstartedtasktoolbar.js
index 0c6fa72..1a60b83 100644
--- a/resources/tours/gettingstartedtasktoolbar.js
+++ b/resources/tours/gettingstartedtasktoolbar.js
@@ -2,6 +2,8 @@
 // Used for wikitext editing.  The 'gettingstartedtasktoolbarve' tour is for 
VisualEditor.
 
 ( function ( window, document, $, mw, gt ) {
+       'use strict';
+
        var task = mw.gettingStarted.logging.getTaskForCurrentPage() || '',
                hasEditSection;
 
diff --git a/resources/tours/gettingstartedtasktoolbarintro.js 
b/resources/tours/gettingstartedtasktoolbarintro.js
index 7a52430..8942616 100644
--- a/resources/tours/gettingstartedtasktoolbarintro.js
+++ b/resources/tours/gettingstartedtasktoolbarintro.js
@@ -1,6 +1,8 @@
 // Tour started on article page, with task toolbar showing
 
 ( function ( window, document, $, mw, gt ) {
+       'use strict';
+
        gt.defineTour( {
                name: 'gettingstartedtasktoolbarintro',
                shouldLog: true,
diff --git a/resources/tours/gettingstartedtasktoolbarve.js 
b/resources/tours/gettingstartedtasktoolbarve.js
index 5fadfd4..14de76f 100644
--- a/resources/tours/gettingstartedtasktoolbarve.js
+++ b/resources/tours/gettingstartedtasktoolbarve.js
@@ -2,6 +2,8 @@
 // Used for VisualEditor.  The 'gettingstartedtasktoolbar' tour is for 
wikitext editing.
 
 ( function ( $, mw, gt ) {
+       'use strict';
+
        var task = mw.gettingStarted.logging.getTaskForCurrentPage() || '',
                editSectionSelector = '.mw-editsection-visualeditor',
                hasEditSectionAtLoadTime;

-- 
To view, visit https://gerrit.wikimedia.org/r/80342
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib35a5085e7550d57520c383ffe2fe711b0fb470e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/GettingStarted
Gerrit-Branch: master
Gerrit-Owner: Mattflaschen <mflasc...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits