Jdlrobson has uploaded a new change for review. https://gerrit.wikimedia.org/r/80673
Change subject: Desktop: Load pagelist styles on nearby ...................................................................... Desktop: Load pagelist styles on nearby Bug: 53160 Change-Id: Ic9f0737be18e909c44a9e7f05728b3e66765b3fb --- M includes/Resources.php M includes/skins/SkinMinerva.php M includes/specials/SpecialNearby.php 3 files changed, 12 insertions(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend refs/changes/73/80673/1 diff --git a/includes/Resources.php b/includes/Resources.php index bf8d98c..485c633 100644 --- a/includes/Resources.php +++ b/includes/Resources.php @@ -102,6 +102,13 @@ ), ), + 'mobile.pagelist.styles' => $wgMFMobileResourceBoilerplate + array( + 'styles' => array( + 'stylesheets/common/pagelist.css', + ), + 'position' => 'top', + ), + 'mobile.styles' => $wgMFMobileResourceBoilerplate + array( 'styles' => array( 'stylesheets/externals/reset.css', @@ -110,7 +117,6 @@ 'stylesheets/common/typography.css', 'stylesheets/common/footer.css', 'stylesheets/modules/toggle.css', - 'stylesheets/common/pagelist.css', // FIXME: move to module mobile.stable.styles for some reason it breaks RTL when in that module 'stylesheets/common/navigation.css', 'stylesheets/common/overlays.css', diff --git a/includes/skins/SkinMinerva.php b/includes/skins/SkinMinerva.php index bed3602..9516bb4 100644 --- a/includes/skins/SkinMinerva.php +++ b/includes/skins/SkinMinerva.php @@ -18,6 +18,7 @@ parent::initPage( $out ); // add styling $out->addModuleStyles( 'mobile.styles' ); + $out->addModuleStyles( 'mobile.pagelist.styles' ); $out->addJsConfigVars( $this->getSkinConfigVariables() ); } diff --git a/includes/specials/SpecialNearby.php b/includes/specials/SpecialNearby.php index 8996193..ac32c7f 100644 --- a/includes/specials/SpecialNearby.php +++ b/includes/specials/SpecialNearby.php @@ -23,7 +23,10 @@ if ( $ctx->isAlphaGroupMember() ) { $output->addModules( 'mobile.nearby.watchstar' ); } - }; + } else { + // Only the Minerva skin loads this module so make sure we load it for desktop + $output->addModuleStyles( 'mobile.pagelist.styles' ); + } $output->setPageTitle( wfMessage( 'mobile-frontend-nearby-title' )->escaped() ); -- To view, visit https://gerrit.wikimedia.org/r/80673 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ic9f0737be18e909c44a9e7f05728b3e66765b3fb Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/MobileFrontend Gerrit-Branch: master Gerrit-Owner: Jdlrobson <jrob...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits