Umherirrender has uploaded a new change for review.
https://gerrit.wikimedia.org/r/80721
Change subject: Do not show empty metadata section on svgs
......................................................................
Do not show empty metadata section on svgs
The SvgHandler does not output all metadata, that means the returned
array can be empty. In this case return false to indicate that the
metadata section should not be added on the image description page.
Change-Id: I989154dbaaaafb2e924838c990e30a9ffe6842a9
---
M includes/media/SVG.php
1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/21/80721/1
diff --git a/includes/media/SVG.php b/includes/media/SVG.php
index 28083a7..4c055a5 100644
--- a/includes/media/SVG.php
+++ b/includes/media/SVG.php
@@ -348,6 +348,7 @@
'description' => 'imagedescription',
'title' => 'objectname',
);
+ $showMeta = false;
foreach ( $metadata as $name => $value ) {
$tag = strtolower( $name );
if ( isset( $conversion[$tag] ) ) {
@@ -356,6 +357,7 @@
// Do not output other metadata not in list
continue;
}
+ $showMeta = true;
self::addMeta( $result,
in_array( $tag, $visibleFields ) ? 'visible' :
'collapsed',
'exif',
@@ -363,7 +365,7 @@
$value
);
}
- return $result;
+ return $showMeta ? $result : false;
}
--
To view, visit https://gerrit.wikimedia.org/r/80721
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I989154dbaaaafb2e924838c990e30a9ffe6842a9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Umherirrender <umherirrender_de...@web.de>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
