jenkins-bot has submitted this change and it was merged.
Change subject: Improve snak testToArrayRoundtrip test.
......................................................................
Improve snak testToArrayRoundtrip test.
The ->equals() method basically justchecks
to see thet the classtype is correct and
the hashes are the same. Having these checks
in the test allows failure output to be more
usefull
This will naturally not pass unitl the issue is
fixed in Change: Ic66442813528bb30
Change-Id: Idaa7bc41f1aee70b8e2897fdda4de73ea353a520
---
M tests/phpunit/Snak/SnakTest.php
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Aude: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tests/phpunit/Snak/SnakTest.php b/tests/phpunit/Snak/SnakTest.php
index e8656bf..73c95f6 100644
--- a/tests/phpunit/Snak/SnakTest.php
+++ b/tests/phpunit/Snak/SnakTest.php
@@ -132,6 +132,7 @@
$copy = \Wikibase\SnakObject::newFromArray( $data );
$this->assertInstanceOf( '\Wikibase\Snak', $copy,
'newFromArray should return object implementing Snak' );
+ $this->assertEquals( $snak->getHash(),
$copy->getHash(), 'newFromArray should return object with same Hash used
previously' );
$this->assertTrue( $snak->equals( $copy ), 'getArray
newFromArray roundtrip should work' );
}
--
To view, visit https://gerrit.wikimedia.org/r/80795
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Idaa7bc41f1aee70b8e2897fdda4de73ea353a520
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/WikibaseDataModel
Gerrit-Branch: master
Gerrit-Owner: Addshore <addshorew...@gmail.com>
Gerrit-Reviewer: Addshore <addshorew...@gmail.com>
Gerrit-Reviewer: Anja Jentzsch <a...@anjeve.de>
Gerrit-Reviewer: Ataherivand <abraham.taheriv...@wikimedia.de>
Gerrit-Reviewer: Aude <aude.w...@gmail.com>
Gerrit-Reviewer: Daniel Kinzler <daniel.kinz...@wikimedia.de>
Gerrit-Reviewer: Daniel Werner <daniel.wer...@wikimedia.de>
Gerrit-Reviewer: Denny Vrandecic <denny.vrande...@wikimedia.de>
Gerrit-Reviewer: Henning Snater <henning.sna...@wikimedia.de>
Gerrit-Reviewer: Hoo man <h...@online.de>
Gerrit-Reviewer: Jens Ohlig <jens.oh...@wikimedia.de>
Gerrit-Reviewer: Jeroen De Dauw <jeroended...@gmail.com>
Gerrit-Reviewer: John Erling Blad <jeb...@gmail.com>
Gerrit-Reviewer: Liangent <liang...@gmail.com>
Gerrit-Reviewer: Lydia Pintscher <lydia.pintsc...@wikimedia.de>
Gerrit-Reviewer: Markus Kroetzsch <mar...@semantic-mediawiki.org>
Gerrit-Reviewer: Nikola Smolenski <smole...@eunet.rs>
Gerrit-Reviewer: Nilesh <nil...@nileshc.com>
Gerrit-Reviewer: Tobias Gritschacher <tobias.gritschac...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
