jenkins-bot has submitted this change and it was merged.
Change subject: Remove inconsistent font-family declarations
......................................................................
Remove inconsistent font-family declarations
Removed explicit uses of Helvetica Neue, Helvetica and Arial from
mediawiki.ui (currently used in om account creation and login
interface) and post-edit notifications. The browser is allowed to use
its default font instead.
Bug: 44394
Change-Id: I01eec72853b24d530d8733352a68d0a26967488f
---
M resources/mediawiki.action/mediawiki.action.view.postEdit.css
M resources/mediawiki.ui/mediawiki.ui.vector.css
M resources/mediawiki.ui/sourcefiles/scss/mixins/_type.scss
M resources/mediawiki.ui/sourcefiles/scss/settings/_typography.scss
4 files changed, 0 insertions(+), 9 deletions(-)
Approvals:
Mattflaschen: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/mediawiki.action/mediawiki.action.view.postEdit.css
b/resources/mediawiki.action/mediawiki.action.view.postEdit.css
index 12b4691..be88337 100644
--- a/resources/mediawiki.action/mediawiki.action.view.postEdit.css
+++ b/resources/mediawiki.action/mediawiki.action.view.postEdit.css
@@ -32,10 +32,6 @@
transition: all 0.25s ease-in-out;
}
-.skin-vector .postedit {
- font-family: 'Helvetica Neue', Helvetica, Arial, sans-serif;
-}
-
.skin-monobook .postedit {
top: 6em !important;
}
diff --git a/resources/mediawiki.ui/mediawiki.ui.vector.css
b/resources/mediawiki.ui/mediawiki.ui.vector.css
index 94e3300..d55ddc5 100644
--- a/resources/mediawiki.ui/mediawiki.ui.vector.css
+++ b/resources/mediawiki.ui/mediawiki.ui.vector.css
@@ -134,7 +134,6 @@
/* line 3, sourcefiles/scss/components/vector/_buttons.scss */
.mw-ui-button {
- font-family: "Helvetica Neue", "Helvetica", "Arial", sans-serif;
font-size: 1em;
line-height: 1.4em;
}
@@ -375,14 +374,12 @@
.mw-ui-vform,
.mw-ui-vform > div input,
.mw-ui-input {
- font-family: "Helvetica Neue", "Helvetica", "Arial", sans-serif;
font-size: 1em;
line-height: 1.4em;
}
/* line 3, sourcefiles/scss/components/vector/_containers.scss */
.mw-ui-container {
- font-family: "Helvetica Neue", "Helvetica", "Arial", sans-serif;
font-size: 1em;
line-height: 1.4em;
}
diff --git a/resources/mediawiki.ui/sourcefiles/scss/mixins/_type.scss
b/resources/mediawiki.ui/sourcefiles/scss/mixins/_type.scss
index 964d590..8a93a08 100644
--- a/resources/mediawiki.ui/sourcefiles/scss/mixins/_type.scss
+++ b/resources/mediawiki.ui/sourcefiles/scss/mixins/_type.scss
@@ -1,6 +1,5 @@
@mixin vector-type {
font: {
- family: $baseFontFamily;
size: $baseFontSize;
}
line-height: $baseLineHeight;
diff --git a/resources/mediawiki.ui/sourcefiles/scss/settings/_typography.scss
b/resources/mediawiki.ui/sourcefiles/scss/settings/_typography.scss
index 5f0cea2..013d12b 100644
--- a/resources/mediawiki.ui/sourcefiles/scss/settings/_typography.scss
+++ b/resources/mediawiki.ui/sourcefiles/scss/settings/_typography.scss
@@ -1,5 +1,4 @@
$baseFontSize: 1em;
-$baseFontFamily: "Helvetica Neue", "Helvetica", "Arial", sans-serif;
$baseLineHeight: 1.4 * $baseFontSize;
$baseFontColor: $agoraTextColor;
--
To view, visit https://gerrit.wikimedia.org/r/78408
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I01eec72853b24d530d8733352a68d0a26967488f
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Matmarex <matma....@gmail.com>
Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: MZMcBride <w...@mzmcbride.com>
Gerrit-Reviewer: Mattflaschen <mflasc...@wikimedia.org>
Gerrit-Reviewer: Ori.livneh <o...@wikimedia.org>
Gerrit-Reviewer: Spage <sp...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
